lkokhreidze opened a new pull request #8558:
URL: https://github.com/apache/kafka/pull/8558
Added KIP-221 documentation
https://user-images.githubusercontent.com/8927925/80348679-d5a37800-8876-11ea-90a6-b5e30576efbe.png";>
https://user-images.githubusercontent.com/8927925/80348
leonardge commented on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-619813438
The tests that are failing doesn't seem to be relevant to my change which
are the following:
- kafka.api.TransactionsTest.testBumpTransactionalEpoch
-
org.apache.kafka.str
tombentley commented on a change in pull request #8311:
URL: https://github.com/apache/kafka/pull/8311#discussion_r415618607
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -3382,6 +3388,70 @@ public void testAlterClientQuotas
jiamei xie created KAFKA-9922:
-
Summary: Update examples README
Key: KAFKA-9922
URL: https://issues.apache.org/jira/browse/KAFKA-9922
Project: Kafka
Issue Type: Bug
Components: consumer
jiameixie opened a new pull request #8559:
URL: https://github.com/apache/kafka/pull/8559
Class kafka.examples.SimpleConsumerDemo was removed. But the
java-simple-consumer-demo.sh
was not removed and README was not updated.
Change-Id: Iff057ce91454b493859ace6c6959e674048e9678
S
jiameixie commented on pull request #8559:
URL: https://github.com/apache/kafka/pull/8559#issuecomment-619838295
@hachikuji @guozhangwang Call for review
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093228#comment-17093228
]
Lovro Pandžić commented on KAFKA-9603:
--
I've created a public github repository that
[
https://issues.apache.org/jira/browse/KAFKA-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093228#comment-17093228
]
Lovro Pandžić edited comment on KAFKA-9603 at 4/27/20, 9:22 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093312#comment-17093312
]
Bruno Iljazovic commented on KAFKA-9603:
To expand on this, it seems that RocksDB
[
https://issues.apache.org/jira/browse/KAFKA-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Iljazovic updated KAFKA-9603:
---
Affects Version/s: 2.1.0
2.2.0
> Number of open files keeps increasing
[
https://issues.apache.org/jira/browse/KAFKA-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093416#comment-17093416
]
Bruno Cadonna commented on KAFKA-9916:
--
[~guozhang] Thank you for adding all the det
[
https://issues.apache.org/jira/browse/KAFKA-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093416#comment-17093416
]
Bruno Cadonna edited comment on KAFKA-9916 at 4/27/20, 12:15 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093436#comment-17093436
]
Alexandre Dupriez commented on KAFKA-9564:
--
[PR-52|https://github.com/harshach/k
[
https://issues.apache.org/jira/browse/KAFKA-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093436#comment-17093436
]
Alexandre Dupriez edited comment on KAFKA-9564 at 4/27/20, 12:27 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez resolved KAFKA-9549.
--
Resolution: Fixed
> Local storage implementations for RSM which can be used in tests
>
[
https://issues.apache.org/jira/browse/KAFKA-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093416#comment-17093416
]
Bruno Cadonna edited comment on KAFKA-9916 at 4/27/20, 12:33 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093416#comment-17093416
]
Bruno Cadonna edited comment on KAFKA-9916 at 4/27/20, 12:34 PM:
--
tombentley commented on pull request #8311:
URL: https://github.com/apache/kafka/pull/8311#issuecomment-619986596
Rebased for conflict.
@dajac thanks for the review. I agree about the case of the unexpected
partition. The only way it could happen would be a bug in either the client o
showuon opened a new pull request #8560:
URL: https://github.com/apache/kafka/pull/8560
Update the raft introduction link. The old link is not accessible now.
Update to the official usenix conference link where the raft paper published.
It also contains the paper introduction, paper pdf, a
tombentley commented on pull request #8450:
URL: https://github.com/apache/kafka/pull/8450#issuecomment-620014014
@ijuma done & rebased for conflict.
This is an automated message from the Apache Git Service.
To respon
cadonna commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r415797071
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -713,23 +713,18 @@ private boolean ass
WanderingStar commented on pull request #8184:
URL: https://github.com/apache/kafka/pull/8184#issuecomment-620043557
Thanks for your review, @omkreddy! I've rebased and incorporated your
feedback.
This is an automated messag
[
https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093611#comment-17093611
]
Wang Ge commented on KAFKA-9798:
I think this happen again.
See here: [https://builds.ap
leonardge commented on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-620047615
QueryableStateIntegrationTest.shouldAllowConcurrentAccesses JIRA:
https://issues.apache.org/jira/browse/KAFKA-9798
MetricsDuringTopicCreationDeletionTest.testMetricsDuri
leonardge edited a comment on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-620047615
QueryableStateIntegrationTest.shouldAllowConcurrentAccesses JIRA:
https://issues.apache.org/jira/browse/KAFKA-9798
MetricsDuringTopicCreationDeletionTest.testMetr
omkreddy commented on pull request #8184:
URL: https://github.com/apache/kafka/pull/8184#issuecomment-620048310
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093645#comment-17093645
]
Igor Baltiyskiy commented on KAFKA-9912:
I've just reproduced it. Unfortunately,
[
https://issues.apache.org/jira/browse/KAFKA-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093667#comment-17093667
]
Himanshu Tyagi commented on KAFKA-9376:
---
[~pehlivanoglu] Hey I'm facing the same is
[
https://issues.apache.org/jira/browse/KAFKA-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093678#comment-17093678
]
Sophie Blee-Goldman commented on KAFKA-7317:
I replied on the SO question, bu
[
https://issues.apache.org/jira/browse/KAFKA-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093685#comment-17093685
]
Sophie Blee-Goldman commented on KAFKA-9127:
Does it qualify as a regression
[
https://issues.apache.org/jira/browse/KAFKA-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093692#comment-17093692
]
Sophie Blee-Goldman commented on KAFKA-9127:
That said, it does seem like a l
lkokhreidze commented on pull request #8558:
URL: https://github.com/apache/kafka/pull/8558#issuecomment-620101449
call for review @vvcephei @mjsax
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman reopened KAFKA-9798:
Assignee: (was: Guozhang Wang)
> Flaky test:
> org.apache.kafka.streams.inte
[
https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093740#comment-17093740
]
Sophie Blee-Goldman commented on KAFKA-9798:
h3. Stacktrace
java.lang.Assert
[
https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093739#comment-17093739
]
Sophie Blee-Goldman commented on KAFKA-9798:
h3. Stacktrace
java.nio.file.No
junrao commented on pull request #8524:
URL: https://github.com/apache/kafka/pull/8524#issuecomment-620110244
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
ableegoldman commented on a change in pull request #8548:
URL: https://github.com/apache/kafka/pull/8548#discussion_r415991034
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1231,13 +1235,13 @@ public void handle
jeffwidman opened a new pull request #8561:
URL: https://github.com/apache/kafka/pull/8561
Fix typo in mirrormaker 2 configs:
`stoage` --> `storage`
This is an automated message from the Apache Git Service.
To respond to t
[
https://issues.apache.org/jira/browse/KAFKA-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093749#comment-17093749
]
Guozhang Wang commented on KAFKA-9603:
--
Thanks for uploading the reproduction repo g
[
https://issues.apache.org/jira/browse/KAFKA-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman reopened KAFKA-9176:
Saw this fail again on a PR with
h3. Stacktrace
org.apache.kafka.streams.errors.Invali
ableegoldman commented on a change in pull request #8546:
URL: https://github.com/apache/kafka/pull/8546#discussion_r415994385
##
File path: tests/README.md
##
@@ -36,6 +36,10 @@
TC_PATHS="tests/kafkatest/tests/client/pluggable_test.py::PluggableConsumerTest"
```
TC_PATHS="
jeffwidman edited a comment on pull request #2394:
URL: https://github.com/apache/kafka/pull/2394#issuecomment-612325594
That sounds reasonable, created
[KIP-592](https://cwiki.apache.org/confluence/display/KAFKA/KIP-592%3A+MirrorMaker+should+replicate+topics+from+earliest)
and I'll send i
[
https://issues.apache.org/jira/browse/KAFKA-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093757#comment-17093757
]
Guozhang Wang commented on KAFKA-9909:
--
Not sure I can follow here: if you set the c
jtrenholm-jask commented on pull request #8196:
URL: https://github.com/apache/kafka/pull/8196#issuecomment-620121750
I've found when we restart the kafka leader or remove /controller in zk,
this will usually kick the reassignment and it will continue for a while before
stopping again. Is
[
https://issues.apache.org/jira/browse/KAFKA-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-9859:
---
Labels: newbie newbie++ (was: )
> kafka-streams-application-reset tool doesn't take into account top
[
https://issues.apache.org/jira/browse/KAFKA-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Baltiyskiy updated KAFKA-9912:
---
Attachment: broker-logs.zip
> Kafka deletes full log on startup written 30mins ago - wrongly
[
https://issues.apache.org/jira/browse/KAFKA-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093770#comment-17093770
]
Igor Baltiyskiy commented on KAFKA-9912:
Just reproduced again:
{code}bin/kafka-
[
https://issues.apache.org/jira/browse/KAFKA-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Baltiyskiy updated KAFKA-9912:
---
Attachment: tfp-13.consumer.log
> Kafka deletes full log on startup written 30mins ago - wron
steverod opened a new pull request #8562:
URL: https://github.com/apache/kafka/pull/8562
What
Earlier log test changes went into trunk (for KAFKA-9807, KAFKA-9838) and
were cherry-picked to 2.4, but they broke the Scala 2.11 build.
This change cherry-picks the fixes needed to
[
https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093773#comment-17093773
]
Boyang Chen commented on KAFKA-9921:
Hey [~georgi.petkov], would you mind explaining
[
https://issues.apache.org/jira/browse/KAFKA-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093785#comment-17093785
]
Sophie Blee-Goldman commented on KAFKA-7965:
[https://builds.apache.org/job/k
ableegoldman commented on pull request #8548:
URL: https://github.com/apache/kafka/pull/8548#issuecomment-620144298
Flaky test failures:
`QueryableStateIntegrationTest.shouldAllowConcurrentAccesses`
`ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigG
omkreddy commented on pull request #8184:
URL: https://github.com/apache/kafka/pull/8184#issuecomment-620145498
JDK 8, 11 tests passed. JDK 14 test failures are not related. Merging to
trunk.
This is an automated message fro
[
https://issues.apache.org/jira/browse/KAFKA-9612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar resolved KAFKA-9612.
--
Fix Version/s: 2.6.0
Reviewer: Manikumar
Resolution: Fixed
> CLI Dynamic Configuration
Sophie Blee-Goldman created KAFKA-9923:
--
Summary: Join window store duplicates can be compacted in
changelog
Key: KAFKA-9923
URL: https://issues.apache.org/jira/browse/KAFKA-9923
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman updated KAFKA-9923:
---
Priority: Critical (was: Major)
> Join window store duplicates can be compacted in c
[
https://issues.apache.org/jira/browse/KAFKA-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093816#comment-17093816
]
Bruno Cadonna commented on KAFKA-9923:
--
[~ableegoldman] Is https://issues.apache.org
abbccdda commented on a change in pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#discussion_r416057712
##
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##
@@ -297,46 +298,271 @@ class KafkaApisTest {
val topic = "topic"
setup
wj1918 opened a new pull request #8563:
URL: https://github.com/apache/kafka/pull/8563
The "Monitoring and Management Using JMX Technology" link on the operations
page is broken because of a missing double quote in the html a tag.
--
[
https://issues.apache.org/jira/browse/KAFKA-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093842#comment-17093842
]
Sophie Blee-Goldman commented on KAFKA-9923:
The root cause is the same but t
[
https://issues.apache.org/jira/browse/KAFKA-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093842#comment-17093842
]
Sophie Blee-Goldman edited comment on KAFKA-9923 at 4/27/20, 7:00 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093855#comment-17093855
]
Georgi Petkov commented on KAFKA-9921:
--
The same reason you would ever want caching
[
https://issues.apache.org/jira/browse/KAFKA-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093842#comment-17093842
]
Sophie Blee-Goldman edited comment on KAFKA-9923 at 4/27/20, 7:35 PM:
-
bdbyrne commented on a change in pull request #7982:
URL: https://github.com/apache/kafka/pull/7982#discussion_r416110108
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/internals/BufferPoolTest.java
##
@@ -416,6 +418,10 @@ public Void call() throws Excep
ijuma commented on pull request #7982:
URL: https://github.com/apache/kafka/pull/7982#issuecomment-620205559
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093902#comment-17093902
]
Sophie Blee-Goldman commented on KAFKA-9921:
Hey [~georgi.petkov]
You're rig
[
https://issues.apache.org/jira/browse/KAFKA-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-9839.
Fix Version/s: 2.5.1
Resolution: Fixed
> IllegalStateException on metadata update wh
[
https://issues.apache.org/jira/browse/KAFKA-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-9839:
---
Affects Version/s: 2.5.0
2.4.1
> IllegalStateException on metadata upd
[
https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang reassigned KAFKA-9798:
Assignee: Guozhang Wang
> Flaky test:
> org.apache.kafka.streams.integration.QueryableSta
[
https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman reassigned KAFKA-9921:
--
Assignee: Sophie Blee-Goldman
> Caching is not working properly with WindowSta
ableegoldman opened a new pull request #8564:
URL: https://github.com/apache/kafka/pull/8564
These two options are essentially incompatible, as caching will do nothing
to reduce downstream traffic and writes when it has to allow non-unique keys
(skipping records where the value is also the
[
https://issues.apache.org/jira/browse/KAFKA-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-9866.
Fix Version/s: 2.6.0
Resolution: Fixed
Merged the PR to trunk.
> Do not attempt to elect preferred
mjsax commented on pull request #8564:
URL: https://github.com/apache/kafka/pull/8564#issuecomment-620235547
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on pull request #8564:
URL: https://github.com/apache/kafka/pull/8564#issuecomment-620235837
Makes sense to me. +1
Curious to hear what @guozhangwang @vvcephei think?
This is an automated message from t
ijuma commented on a change in pull request #8524:
URL: https://github.com/apache/kafka/pull/8524#discussion_r416151605
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1068,12 +1068,23 @@ class KafkaController(val config: KafkaConfig,
va
guozhangwang opened a new pull request #8565:
URL: https://github.com/apache/kafka/pull/8565
Comparing all other test cases, the `shouldAllowConcurrentAccesses` starts
an async producer sending records throughout the test other than just
synchronously sent and acked a few records before we
guozhangwang commented on pull request #8565:
URL: https://github.com/apache/kafka/pull/8565#issuecomment-620242776
@mjsax @cadonna to take a look.
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093941#comment-17093941
]
Guozhang Wang commented on KAFKA-9798:
--
One more try to fix this: https://github.com
vvcephei commented on pull request #8254:
URL: https://github.com/apache/kafka/pull/8254#issuecomment-620243830
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on pull request #8254:
URL: https://github.com/apache/kafka/pull/8254#issuecomment-620243639
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r416161091
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java
##
@@ -16,49 +16,50 @@
*/
junrao commented on a change in pull request #8524:
URL: https://github.com/apache/kafka/pull/8524#discussion_r416164863
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1068,12 +1068,23 @@ class KafkaController(val config: KafkaConfig,
v
vvcephei commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r416168944
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -713,23 +713,18 @@ private boolean as
vvcephei commented on pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#issuecomment-620251131
The system tests passed, by the way:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-04-24--001.1587784155--vvcephei--kafka-6145-task-ass
[
https://issues.apache.org/jira/browse/KAFKA-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-9885.
Fix Version/s: 2.6.0
Resolution: Fixed
> Evict last members of a group when the maxi
ableegoldman commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r416178865
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java
##
@@ -147,6 +149,9 @@ private void shouldFetchL
ableegoldman commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r416179915
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/HighAvailabilityStreamsPartitionAssignorTest.java
##
@@ -0,0 +1,326 @
vvcephei commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r416185907
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -713,23 +713,18 @@ private boolean as
leonardge commented on a change in pull request #8524:
URL: https://github.com/apache/kafka/pull/8524#discussion_r416186838
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1068,12 +1068,23 @@ class KafkaController(val config: KafkaConfig,
leonardge opened a new pull request #8566:
URL: https://github.com/apache/kafka/pull/8566
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
leonardge commented on pull request #8566:
URL: https://github.com/apache/kafka/pull/8566#issuecomment-620271135
@junrao here is the follower up PR.
This is an automated message from the Apache Git Service.
To respond to the
hachikuji commented on pull request #8562:
URL: https://github.com/apache/kafka/pull/8562#issuecomment-620271189
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ableegoldman commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r416199492
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -713,23 +713,18 @@ private boolea
ableegoldman commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r416200976
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -713,23 +713,18 @@ private boolea
hachikuji commented on pull request #6865:
URL: https://github.com/apache/kafka/pull/6865#issuecomment-620276146
Closing this. I do not have the time to rebase and seems we can do without
the changes. I will consider reopening in the future.
---
ableegoldman commented on a change in pull request #8540:
URL: https://github.com/apache/kafka/pull/8540#discussion_r414822929
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -701,18 +703,33 @@ private KafkaStreams(final InternalTopologyBuil
ableegoldman commented on a change in pull request #8540:
URL: https://github.com/apache/kafka/pull/8540#discussion_r414822929
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -701,18 +703,33 @@ private KafkaStreams(final InternalTopologyBuil
ableegoldman commented on a change in pull request #8540:
URL: https://github.com/apache/kafka/pull/8540#discussion_r416215513
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java
##
@@ -265,12 +270,27 @@ public void shouldR
vvcephei commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r416217370
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java
##
@@ -147,6 +149,9 @@ private void shouldFetchLagsD
ijuma opened a new pull request #8567:
URL: https://github.com/apache/kafka/pull/8567
After KIP-219, responses are sent immediately and we rely on a combination
of clients and muting of the channel to throttle. The result of this is that
we need to track `apiThrottleTimeMs` as an expli
1 - 100 of 149 matches
Mail list logo
