[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413563167 ## File path: core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala ## @@ -60,6 +61,7 @@ class ReplicaAlterLogDirsThreadTest {

[GitHub] [kafka] lbradstreet commented on issue #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
lbradstreet commented on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-618220519 I updated the PR to use Time everywhere that's required. Note that I did not switch the fetcher tests to use MockTime as it appears they are timing dependent and may depend on Abstra

[GitHub] [kafka] lbradstreet edited a comment on issue #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
lbradstreet edited a comment on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-618220519 I updated the PR to pass Time everywhere that's required. Note that I did not switch the fetcher tests to use MockTime as it appears they are timing dependent and may depend o

[GitHub] [kafka] dajac commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-04-23 Thread GitBox
dajac commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r413546760 ## File path: clients/src/test/java/org/apache/kafka/common/requests/AlterReplicaLogDirsResponseTest.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] ijuma commented on issue #8513: MINOR: jackson 2.10.3

2020-04-23 Thread GitBox
ijuma commented on issue #8513: URL: https://github.com/apache/kafka/pull/8513#issuecomment-618224164 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413563167 ## File path: core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala ## @@ -60,6 +61,7 @@ class ReplicaAlterLogDirsThreadTest {

[GitHub] [kafka] ijuma commented on issue #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
ijuma commented on issue #8467: URL: https://github.com/apache/kafka/pull/8467#issuecomment-618225193 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] ijuma commented on issue #8464: KAFKA-9852: Change the max duration that calls to the buffer pool can block from 2000ms to 10ms

2020-04-23 Thread GitBox
ijuma commented on issue #8464: URL: https://github.com/apache/kafka/pull/8464#issuecomment-618226016 Unrelated failed flaky test: > kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup -

[GitHub] [kafka] ijuma commented on issue #8456: MINOR: Annotate KafkaAdminClientTest.testAlterClientQuotas() with @Test

2020-04-23 Thread GitBox
ijuma commented on issue #8456: URL: https://github.com/apache/kafka/pull/8456#issuecomment-618226721 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] ijuma commented on a change in pull request #8450: KAFKA-7613: Enable -Xlint:rawtypes in clients, fixing warnings

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8450: URL: https://github.com/apache/kafka/pull/8450#discussion_r413572295 ## File path: build.gradle ## @@ -1103,8 +1103,14 @@ project(':clients') { } compileJava.dependsOn 'processMessages' + compileJava { +options.com

[GitHub] [kafka] tombentley commented on issue #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

2020-04-23 Thread GitBox
tombentley commented on issue #8417: URL: https://github.com/apache/kafka/pull/8417#issuecomment-618227764 Thanks @ijuma This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] ijuma commented on a change in pull request #8449: KAFKA-7613: Enable -Xlint:try, fixing warnings

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8449: URL: https://github.com/apache/kafka/pull/8449#discussion_r413573833 ## File path: clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java ## @@ -32,6 +32,7 @@ * using the default constructor and will the

[GitHub] [kafka] leonardge commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-23 Thread GitBox
leonardge commented on issue #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-618229704 Why is the CI failing? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma commented on issue #8427: KAFKA-9761: Use Admin Client default timeout instead of using 5sec timeout default

2020-04-23 Thread GitBox
ijuma commented on issue #8427: URL: https://github.com/apache/kafka/pull/8427#issuecomment-618230317 Thanks for the PR. Since this has potential compatibility implications, it requires a KIP. This is an automated message fr

[jira] [Commented] (KAFKA-9903) kafka ShutdownableThread judge thread isRuning status has some bug

2020-04-23 Thread shilin Lu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090355#comment-17090355 ] shilin Lu commented on KAFKA-9903: -- [~guozhang] [~ijuma] > kafka ShutdownableThread ju

[GitHub] [kafka] ijuma commented on issue #8429: MINOR: Enable fatal warnings with scala 2.13

2020-04-23 Thread GitBox
ijuma commented on issue #8429: URL: https://github.com/apache/kafka/pull/8429#issuecomment-618238203 Unrelated flaky test failure in 1 (out of 3) jobs: > kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete ---

[GitHub] [kafka] stanislavkozlovski commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-23 Thread GitBox
stanislavkozlovski commented on issue #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-618264305 JDK 8 failed with ``` 06:01:27 # 06:01:27 # There is insufficient memory for the Java Runtime Environment to continue. 06:01:27 # Cannot create GC thread. Out of sy

[GitHub] [kafka] leonardge commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-23 Thread GitBox
leonardge commented on issue #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-618264854 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] leonardge removed a comment on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-23 Thread GitBox
leonardge removed a comment on issue #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-618264854 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618276927 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] zshuo commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
zshuo commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618278914 Is there anything else I need to do before it gets merged? This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618280153 @zshuo No. I've taken a look at the change and it looks good. By commenting `ok to test`, I triggered the Jenkins builds. If those builds pass, I'll merge your PR

[GitHub] [kafka] mimaison commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-04-23 Thread GitBox
mimaison commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r413647728 ## File path: core/src/test/scala/unit/kafka/admin/DescribeConsumerGroupTest.scala ## @@ -52,11 +51,25 @@ class DescribeConsumerGroupTest extends Consumer

[GitHub] [kafka] cadonna commented on issue #8532: HOTFIX: Fix broker bounce system tests

2020-04-23 Thread GitBox
cadonna commented on issue #8532: URL: https://github.com/apache/kafka/pull/8532#issuecomment-618292163 Streams system tests above are green. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] lrytz commented on a change in pull request #8429: MINOR: Enable fatal warnings with scala 2.13

2020-04-23 Thread GitBox
lrytz commented on a change in pull request #8429: URL: https://github.com/apache/kafka/pull/8429#discussion_r413662887 ## File path: build.gradle ## @@ -484,6 +484,12 @@ subprojects { scalaCompileOptions.additionalParameters += ["-opt:l:inline"] scalaCompileOptions.a

[GitHub] [kafka] zshuo commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
zshuo commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618311862 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618329701 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] cmccabe commented on a change in pull request #8527: Splitted unit tests for --zookeeper flag removal

2020-04-23 Thread GitBox
cmccabe commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r413713907 ## File path: core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala ## @@ -1408,13 +1408,23 @@ class DynamicBrokerReconfigura

[GitHub] [kafka] mimaison commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-04-23 Thread GitBox
mimaison commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r413717848 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -1553,6 +1554,50 @@ class KafkaApisTest { assertEquals(Errors.INVALID_RE

[GitHub] [kafka] tombentley commented on a change in pull request #8449: KAFKA-7613: Enable -Xlint:try, fixing warnings

2020-04-23 Thread GitBox
tombentley commented on a change in pull request #8449: URL: https://github.com/apache/kafka/pull/8449#discussion_r413718361 ## File path: clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java ## @@ -32,6 +32,7 @@ * using the default constructor and wil

[GitHub] [kafka] cmccabe commented on issue #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on issue #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-618334410 For `ConfigCommandTest.scala`, we should keep the tests of the `--zookeeper` command since that is still present in trunk. The goal should be to remove unnecessary dependencies on

[GitHub] [kafka] cmccabe commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r413718893 ## File path: core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala ## @@ -227,8 +227,10 @@ class DeleteTopicTest extends ZooKeeperTestHarness { }

[GitHub] [kafka] cmccabe commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r413719892 ## File path: core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala ## @@ -255,7 +225,7 @@ class ReassignPartitionsCommandArgsTest {

[GitHub] [kafka] cmccabe commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r413720950 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -293,13 +293,6 @@ class TopicCommandWithAdminClientTest exte

[jira] [Created] (KAFKA-9908) Kafka client always trying "kinit -R" even the ticketCache has been renewed by external

2020-04-23 Thread Bob Wen (Jira)
Bob Wen created KAFKA-9908: -- Summary: Kafka client always trying "kinit -R" even the ticketCache has been renewed by external Key: KAFKA-9908 URL: https://issues.apache.org/jira/browse/KAFKA-9908 Project: Ka

[GitHub] [kafka] cmccabe commented on issue #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on issue #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-618337731 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] cmccabe commented on issue #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on issue #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-618338178 Looks like the JDK8 build flaked. ``` 11:00:07 Error occurred during initialization of VM 11:00:07 java.lang.OutOfMemoryError: unable to create new native thread ``` We've g

[GitHub] [kafka] cmccabe edited a comment on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe edited a comment on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618341335 > For the scram credential related code piece, switched to using --bootstrap-server even we don't support it yet. We need to keep using --zookeeper in the SCRAM case since w

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618341335 > For the scram credential related code piece, switched to using --bootstrap-server even we don't support it yet. We need to keep using --zookeeper in the SCRAM case since we don't hav

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618342661 It looks like the places where we invoke `kafka-configs.sh` still need to be converted over to use `--bootstrap-server`

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618343269 Same issue with `kafka-reassign-partitions.sh`. It also needs to be converted to use `--bootstrap-server`. This is an a

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618343631 There are a lot of whitespace-only changes in this PR that are kind of confusing. Can you please do these in a separate PR or just drop them? --

[jira] [Created] (KAFKA-9909) Kafka Streams : offset control to Streams API

2020-04-23 Thread Gopikrishna (Jira)
Gopikrishna created KAFKA-9909: -- Summary: Kafka Streams : offset control to Streams API Key: KAFKA-9909 URL: https://issues.apache.org/jira/browse/KAFKA-9909 Project: Kafka Issue Type: Improveme

[GitHub] [kafka] mimaison commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-04-23 Thread GitBox
mimaison commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r413794118 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -84,6 +87,15 @@ object ConsumerGroupCommand extends Logging { } }

[GitHub] [kafka] mimaison commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-04-23 Thread GitBox
mimaison commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r413794118 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -84,6 +87,15 @@ object ConsumerGroupCommand extends Logging { } }

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618400831 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-61840 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on issue #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
ijuma commented on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-618409553 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] ijuma commented on issue #8537: KAFKA-9907: Switch default build to Scala 2.13

2020-04-23 Thread GitBox
ijuma commented on issue #8537: URL: https://github.com/apache/kafka/pull/8537#issuecomment-618412385 Thanks, I addressed the comment and I merged to trunk. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] ijuma commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r413826884 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir to log

[GitHub] [kafka] ijuma commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r413826884 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir to log

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618418722 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (KAFKA-9907) Switch default build to Scala 2.13

2020-04-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-9907. Resolution: Fixed > Switch default build to Scala 2.13 > -- > >

[jira] [Commented] (KAFKA-9603) Number of open files keeps increasing in Streams application

2020-04-23 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090649#comment-17090649 ] Lovro Pandžić commented on KAFKA-9603: -- Sadly, I've been unable to reproduce the iss

[GitHub] [kafka] ijuma opened a new pull request #8538: MINOR: Pass `-release 8` to scalac and upgrade to Gradle 6.4

2020-04-23 Thread GitBox
ijuma opened a new pull request #8538: URL: https://github.com/apache/kafka/pull/8538 The version of Zinc included with Gradle 6.4 includes a fix for the blocker that was preventing us from passing `-release 8` to scalac. Release notes for Gradle 6.4: https://docs.gradle.org

[GitHub] [kafka] ijuma commented on issue #8364: MINOR: Partition is under reassignment when adding and removing

2020-04-23 Thread GitBox
ijuma commented on issue #8364: URL: https://github.com/apache/kafka/pull/8364#issuecomment-618429581 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] ijuma commented on issue #8151: MINOR: Add missing @Test annotations to miscellaneous tests

2020-04-23 Thread GitBox
ijuma commented on issue #8151: URL: https://github.com/apache/kafka/pull/8151#issuecomment-618430121 @stanislavkozlovski any thoughts on the comments above? This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] ijuma commented on issue #7231: MINOR: Log firstUnstableOffset in debug log line in LogCleanerManager#cleanableOffsets

2020-04-23 Thread GitBox
ijuma commented on issue #7231: URL: https://github.com/apache/kafka/pull/7231#issuecomment-618430662 Looks like this has a conflict. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] bbejeck commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-04-23 Thread GitBox
bbejeck commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r413860696 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -989,16 +994,18 @@ private void to(final TopicNameExt

[GitHub] [kafka] bbejeck commented on issue #8504: KAFKA-9298: reuse mapped stream error in joins

2020-04-23 Thread GitBox
bbejeck commented on issue #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-618447861 >Why that? Because such a topology would hit the bug, it could never be deployed, and thus nobody can actually run such a topology? In fact, shouldn't be "burn" and index even if a name

[GitHub] [kafka] bbejeck commented on issue #8504: KAFKA-9298: reuse mapped stream error in joins

2020-04-23 Thread GitBox
bbejeck commented on issue #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-618450970 @mjsax thanks for the review! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] junrao commented on issue #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm

2020-04-23 Thread GitBox
junrao commented on issue #8489: URL: https://github.com/apache/kafka/pull/8489#issuecomment-618473781 @cmccabe : Does this look good to you? Thanks. This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

2020-04-23 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090711#comment-17090711 ] Jun Rao commented on KAFKA-2419: Sensor expiring is only used on the broker. For the clie

[jira] [Commented] (KAFKA-9603) Number of open files keeps increasing in Streams application

2020-04-23 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090715#comment-17090715 ] Bruno Cadonna commented on KAFKA-9603: -- [~lpandzic] Thank you for the information.

[jira] [Commented] (KAFKA-9747) No tasks created for a connector

2020-04-23 Thread Patrick Szalapski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090718#comment-17090718 ] Patrick Szalapski commented on KAFKA-9747: -- Yes, please at least give a WARN or

[jira] [Comment Edited] (KAFKA-9747) No tasks created for a connector

2020-04-23 Thread Patrick Szalapski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090718#comment-17090718 ] Patrick Szalapski edited comment on KAFKA-9747 at 4/23/20, 4:03 PM: ---

[GitHub] [kafka] abbccdda commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-04-23 Thread GitBox
abbccdda commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r413925987 ## File path: clients/src/main/java/org/apache/kafka/common/requests/EpochEndOffset.java ## @@ -86,4 +84,9 @@ public boolean equals(Object o) { publi

[jira] [Commented] (KAFKA-9652) Throttle time metric needs to be updated for KIP-219

2020-04-23 Thread Agam Brahma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090732#comment-17090732 ] Agam Brahma commented on KAFKA-9652: Not working on this right now, please go ahead.

[jira] [Assigned] (KAFKA-9652) Throttle time metric needs to be updated for KIP-219

2020-04-23 Thread Agam Brahma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Agam Brahma reassigned KAFKA-9652: -- Assignee: Ismael Juma (was: Agam Brahma) > Throttle time metric needs to be updated for KIP-2

[GitHub] [kafka] hachikuji commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-23 Thread GitBox
hachikuji commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-618497996 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] hachikuji commented on issue #8454: KAFKA-9844; Maximum number of members within a group is not always enforced due to a race condition in join group

2020-04-23 Thread GitBox
hachikuji commented on issue #8454: URL: https://github.com/apache/kafka/pull/8454#issuecomment-618505412 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618536956 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on issue #8538: MINOR: Pass `-release 8` to scalac and upgrade to Gradle 6.4

2020-04-23 Thread GitBox
ijuma commented on issue #8538: URL: https://github.com/apache/kafka/pull/8538#issuecomment-618541154 1 flaky failure: > kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup -

[GitHub] [kafka] guozhangwang commented on issue #8326: KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol

2020-04-23 Thread GitBox
guozhangwang commented on issue #8326: URL: https://github.com/apache/kafka/pull/8326#issuecomment-618541912 test this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ijuma commented on issue #8231: Set "-Ywarn-unused" compiler flags when using 2.12

2020-04-23 Thread GitBox
ijuma commented on issue #8231: URL: https://github.com/apache/kafka/pull/8231#issuecomment-618544406 @mumrah we have switched to 2.13 as the default and it has fatal warnings enabled, so I think that's the better place to focus. It wasn't clear to me if 2.13 is catching all the unused war

[GitHub] [kafka] ijuma edited a comment on issue #8231: Set "-Ywarn-unused" compiler flags when using 2.12

2020-04-23 Thread GitBox
ijuma edited a comment on issue #8231: URL: https://github.com/apache/kafka/pull/8231#issuecomment-618544406 @mumrah we have switched to 2.13 as the default and enabled fatal warnings, so I think that's the better place to focus. It wasn't clear to me if 2.13 is catching all the unused war

[GitHub] [kafka] rhauch commented on a change in pull request #8536: KAFKA-9883: Add better error message when REST API forwards a request and leader is not known

2020-04-23 Thread GitBox
rhauch commented on a change in pull request #8536: URL: https://github.com/apache/kafka/pull/8536#discussion_r414006134 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java ## @@ -341,7 +341,15 @@ private void che

[GitHub] [kafka] rhauch commented on issue #8536: KAFKA-9883: Add better error message when REST API forwards a request and leader is not known

2020-04-23 Thread GitBox
rhauch commented on issue #8536: URL: https://github.com/apache/kafka/pull/8536#issuecomment-618552614 Thanks, @kkonstantine. I've incorporated your suggestions. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] leonardge commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

2020-04-23 Thread GitBox
leonardge commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r414012223 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,7 +1068,9 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-04-23 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r414016126 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -263,17 +267,20 @@ public boolean startConnector(

[GitHub] [kafka] cmccabe commented on issue #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm

2020-04-23 Thread GitBox
cmccabe commented on issue #8489: URL: https://github.com/apache/kafka/pull/8489#issuecomment-618573775 This looks reasonable. What testing have we done so far? This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] guozhangwang commented on a change in pull request #8445: KAFKA-9823: Remember the sent generation for the coordinator request

2020-04-23 Thread GitBox
guozhangwang commented on a change in pull request #8445: URL: https://github.com/apache/kafka/pull/8445#discussion_r414027883 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java ## @@ -466,24 +477,193 @@ public void te

[GitHub] [kafka] junrao commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

2020-04-23 Thread GitBox
junrao commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r414042238 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,7 +1068,12 @@ class KafkaController(val config: KafkaConfig, va

[GitHub] [kafka] bseenu commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-23 Thread GitBox
bseenu commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-618596724 @thspinto @ning2008wisc i am trying this , but i do not see the consumer offsets being populated on the target side, my consumer group is not dead i am polling for messages every 5

[GitHub] [kafka] bseenu edited a comment on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-23 Thread GitBox
bseenu edited a comment on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-618596724 @thspinto @ning2008wisc i am trying this , but i do not see the consumer offsets being populated on the target side, my consumer group is not dead i am polling for messages

[jira] [Resolved] (KAFKA-9823) Consumer should check equality of the generation for coordinator requests

2020-04-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9823. -- Fix Version/s: 2.6.0 Resolution: Fixed > Consumer should check equality of the generatio

[GitHub] [kafka] abbccdda commented on pull request #8326: KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol

2020-04-23 Thread GitBox
abbccdda commented on pull request #8326: URL: https://github.com/apache/kafka/pull/8326#issuecomment-618627112 Test only fails the flaky test: kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

[jira] [Created] (KAFKA-9911) Implement new producer fenced error

2020-04-23 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-9911: -- Summary: Implement new producer fenced error Key: KAFKA-9911 URL: https://issues.apache.org/jira/browse/KAFKA-9911 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-9910) Implement new transaction timed out error

2020-04-23 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-9910: -- Summary: Implement new transaction timed out error Key: KAFKA-9910 URL: https://issues.apache.org/jira/browse/KAFKA-9910 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-23 Thread GitBox
ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-618639865 @vvcephei Thanks for all the help! It would've probably taken me quite a while to get through all this by myself. I will update PR shortly. :) ---

[GitHub] [kafka] cmccabe opened a new pull request #8539: MINOR: equals() should compare all fields for generated classes

2020-04-23 Thread GitBox
cmccabe opened a new pull request #8539: URL: https://github.com/apache/kafka/pull/8539 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] lbradstreet commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
lbradstreet commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414100944 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir

[GitHub] [kafka] lbradstreet commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
lbradstreet commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414100944 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir

[GitHub] [kafka] lbradstreet commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
lbradstreet commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414101438 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir

[GitHub] [kafka] lbradstreet commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
lbradstreet commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414100944 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir

[GitHub] [kafka] ijuma commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414106367 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir to log

[GitHub] [kafka] ijuma commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414105901 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir to log

[GitHub] [kafka] ijuma commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414106806 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir to log

[jira] [Resolved] (KAFKA-9844) Maximum number of members within a group is not always enforced due to a race condition in join group

2020-04-23 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9844. Fix Version/s: 2.6.0 Resolution: Fixed > Maximum number of members within a group is

[jira] [Created] (KAFKA-9912) Kafka deletes full log on startup written 30mins ago - wrongly claims retention time 7d breach

2020-04-23 Thread Igor Baltiyskiy (Jira)
Igor Baltiyskiy created KAFKA-9912: -- Summary: Kafka deletes full log on startup written 30mins ago - wrongly claims retention time 7d breach Key: KAFKA-9912 URL: https://issues.apache.org/jira/browse/KAFKA-9912

  1   2   >