[GitHub] [kafka] tombentley commented on a change in pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

tombentley commented on a change in pull request #8417: URL: https://github.com/apache/kafka/pull/8417#discussion_r412754269 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java ## @@ -57,6 +59,10 @@ public ByteBuffer serialize(ApiKeys api

[GitHub] [kafka] dajac commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

dajac commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r412287554 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -2207,21 +2212,33 @@ public AlterReplicaLogDirsResult alterRe

[GitHub] [kafka] dajac commented on a change in pull request #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

dajac commented on a change in pull request #8509: URL: https://github.com/apache/kafka/pull/8509#discussion_r412807377 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -1553,6 +1552,179 @@ class KafkaApisTest { assertEquals(Errors.INVALID_REQU

[jira] [Created] (KAFKA-9902) java client api can not completely take out the kafka-consumer-groups.sh output of information

startjava created KAFKA-9902: Summary: java client api can not completely take out the kafka-consumer-groups.sh output of information Key: KAFKA-9902 URL: https://issues.apache.org/jira/browse/KAFKA-9902

[GitHub] [kafka] leonardge commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

leonardge commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r412857024 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1066,6 +1066,7 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] harshitshah4 edited a comment on issue #8512: KAFKA-6024: Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

harshitshah4 edited a comment on issue #8512: URL: https://github.com/apache/kafka/pull/8512#issuecomment-616683601 @omkreddy @hachikuji can you review the changes ? This is an automated message from the Apache Git Service.

[GitHub] [kafka] harshitshah4 removed a comment on issue #8512: KAFKA-6024: Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

harshitshah4 removed a comment on issue #8512: URL: https://github.com/apache/kafka/pull/8512#issuecomment-617756461 I feel that there are more methods that may require similar changes . This is an automated message from the

[GitHub] [kafka] harshitshah4 commented on issue #8512: KAFKA-6024: Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

harshitshah4 commented on issue #8512: URL: https://github.com/apache/kafka/pull/8512#issuecomment-617756461 I feel that there are more methods that may require similar changes . This is an automated message from the Apache G

[GitHub] [kafka] tombentley commented on issue #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

tombentley commented on issue #8311: URL: https://github.com/apache/kafka/pull/8311#issuecomment-617764518 Thanks @dajac, there were some useful comments and good spots there. I've pushed some fixes. This is an automated mes

[GitHub] [kafka] chia7712 commented on a change in pull request #8530: KAFKA-9388: Refactor integration tests to always use different application ids

chia7712 commented on a change in pull request #8530: URL: https://github.com/apache/kafka/pull/8530#discussion_r412959693 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java ## @@ -119,7 +124,7 @@ public void shouldRestoreState

[GitHub] [kafka] stanislavkozlovski commented on issue #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

stanislavkozlovski commented on issue #8524: URL: https://github.com/apache/kafka/pull/8524#issuecomment-617770854 After discussing online, we figured there isn't an easy way to test this scenario. There's significant work to be done to make KafkaController unit test-able Good catch

[GitHub] [kafka] ijuma commented on issue #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

ijuma commented on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-617772737 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] ijuma commented on a change in pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

ijuma commented on a change in pull request #8417: URL: https://github.com/apache/kafka/pull/8417#discussion_r412973974 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionReassignmentsResponse.java ## @@ -66,14 +64,12 @@ public int throttleTimeM

[jira] [Commented] (KAFKA-9652) Throttle time metric needs to be updated for KIP-219

[ https://issues.apache.org/jira/browse/KAFKA-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089674#comment-17089674 ] Ismael Juma commented on KAFKA-9652: [~agam] Are you working on this? While looking a

[jira] [Assigned] (KAFKA-9589) LogValidatorTest#testLogAppendTimeNonCompressedV2 is not executed and does not pass

[ https://issues.apache.org/jira/browse/KAFKA-9589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wang Ge reassigned KAFKA-9589: -- Assignee: Wang Ge > LogValidatorTest#testLogAppendTimeNonCompressedV2 is not executed and does > not

[jira] [Created] (KAFKA-9903) kafka ShutdownableThread judge thread isRuning status has some bug

shilin Lu created KAFKA-9903: Summary: kafka ShutdownableThread judge thread isRuning status has some bug Key: KAFKA-9903 URL: https://issues.apache.org/jira/browse/KAFKA-9903 Project: Kafka Is

[jira] [Commented] (KAFKA-9903) kafka ShutdownableThread judge thread isRuning status has some bug

[ https://issues.apache.org/jira/browse/KAFKA-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089688#comment-17089688 ] shilin Lu commented on KAFKA-9903: -- [~guozhang] [~ijuma] please take a look at this issu

[GitHub] [kafka] tombentley commented on a change in pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

tombentley commented on a change in pull request #8417: URL: https://github.com/apache/kafka/pull/8417#discussion_r413002568 ## File path: clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java ## @@ -95,13 +94,8 @@ public OffsetCommitResponseData dat

[GitHub] [kafka] tombentley commented on issue #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

tombentley commented on issue #8417: URL: https://github.com/apache/kafka/pull/8417#issuecomment-617793326 @ijuma fixed your comments. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] tombentley commented on a change in pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

tombentley commented on a change in pull request #8417: URL: https://github.com/apache/kafka/pull/8417#discussion_r413002862 ## File path: clients/src/main/java/org/apache/kafka/common/requests/TxnOffsetCommitResponse.java ## @@ -91,7 +91,9 @@ public int throttleTimeMs() {

[GitHub] [kafka] ijuma commented on issue #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

ijuma commented on issue #8417: URL: https://github.com/apache/kafka/pull/8417#issuecomment-617797442 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] ijuma commented on issue #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

ijuma commented on issue #8417: URL: https://github.com/apache/kafka/pull/8417#issuecomment-617798142 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] ijuma commented on issue #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

ijuma commented on issue #8417: URL: https://github.com/apache/kafka/pull/8417#issuecomment-617798318 @tombentley can you please update the PR description to summarize the perf testing you did? This is an automated message f

[GitHub] [kafka] tombentley commented on issue #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

tombentley commented on issue #8417: URL: https://github.com/apache/kafka/pull/8417#issuecomment-617802853 @ijuma done. This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on issue #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

ijuma commented on issue #8417: URL: https://github.com/apache/kafka/pull/8417#issuecomment-617808555 Perfect, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413074912 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,19 @@ import java.util.concurrent._ import org.apache.kafka.common.u

[GitHub] [kafka] ijuma commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

ijuma commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413076253 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,19 @@ import java.util.concurrent._ import org.apache.kafka.common.utils.T

[GitHub] [kafka] ijuma commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

ijuma commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413076253 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,19 @@ import java.util.concurrent._ import org.apache.kafka.common.utils.T

[GitHub] [kafka] ijuma commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

ijuma commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413076253 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,19 @@ import java.util.concurrent._ import org.apache.kafka.common.utils.T

[GitHub] [kafka] ijuma commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

ijuma commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413077069 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,19 @@ import java.util.concurrent._ import org.apache.kafka.common.utils.T

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413085641 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,19 @@ import java.util.concurrent._ import org.apache.kafka.common.u

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413086046 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,19 @@ import java.util.concurrent._ import org.apache.kafka.common.u

[GitHub] [kafka] hachikuji commented on a change in pull request #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

hachikuji commented on a change in pull request #8509: URL: https://github.com/apache/kafka/pull/8509#discussion_r413091037 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3084,12 +3084,7 @@ class KafkaApis(val requestChannel: RequestChannel, // Broke

[jira] [Created] (KAFKA-9904) Use ThreadLocalConcurrent to Replace Random

David Mollitor created KAFKA-9904: - Summary: Use ThreadLocalConcurrent to Replace Random Key: KAFKA-9904 URL: https://issues.apache.org/jira/browse/KAFKA-9904 Project: Kafka Issue Type: Impro

[GitHub] [kafka] belugabehr opened a new pull request #8531: KAFAKA-9904: Use ThreadLocalConcurrent to Replace Random

belugabehr opened a new pull request #8531: URL: https://github.com/apache/kafka/pull/8531 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[GitHub] [kafka] cadonna opened a new pull request #8532: HOTFIX: Fix broker bounce system tests

cadonna opened a new pull request #8532: URL: https://github.com/apache/kafka/pull/8532 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade not

[GitHub] [kafka] cadonna commented on issue #8532: HOTFIX: Fix broker bounce system tests

cadonna commented on issue #8532: URL: https://github.com/apache/kafka/pull/8532#issuecomment-617869532 Call for review: @mjsax @abbccdda This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] cadonna commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests

cadonna commented on a change in pull request #8532: URL: https://github.com/apache/kafka/pull/8532#discussion_r413110487 ## File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py ## @@ -164,7 +164,7 @@ def setup_system(self, start_processor=True, num_threads=3)

[GitHub] [kafka] cadonna commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests

cadonna commented on a change in pull request #8532: URL: https://github.com/apache/kafka/pull/8532#discussion_r413116285 ## File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py ## @@ -164,7 +164,7 @@ def setup_system(self, start_processor=True, num_threads=3)

[GitHub] [kafka] cadonna commented on issue #8532: HOTFIX: Fix broker bounce system tests

cadonna commented on issue #8532: URL: https://github.com/apache/kafka/pull/8532#issuecomment-617883911 Streams system tests run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3914 This is an automated me

[GitHub] [kafka] leonardge opened a new pull request #8533: Fixed bug in log validator tests.

leonardge opened a new pull request #8533: URL: https://github.com/apache/kafka/pull/8533 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] dajac commented on issue #8454: KAFKA-9844; Maximum number of members within a group is not always enforced due to a race condition in join group

dajac commented on issue #8454: URL: https://github.com/apache/kafka/pull/8454#issuecomment-617907578 @hachikuji Could we get this one merged? This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (KAFKA-6817) UnknownProducerIdException when writing messages with old timestamps

[ https://issues.apache.org/jira/browse/KAFKA-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089869#comment-17089869 ] Matthias J. Sax commented on KAFKA-6817: [~bob-barrett] – do you think KIP-360 fu

[GitHub] [kafka] guozhangwang commented on a change in pull request #8530: KAFKA-9388: Refactor integration tests to always use different application ids

guozhangwang commented on a change in pull request #8530: URL: https://github.com/apache/kafka/pull/8530#discussion_r413168976 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinPseudoTopicTest.java ## @@ -1,138 +0,0 @@ -/* - * L

[GitHub] [kafka] vinothchandar opened a new pull request #8534: KAFKA-9512: Backport Flaky Test LagFetchIntegrationTest.shouldFetchLagsDuringRestoration

vinothchandar opened a new pull request #8534: URL: https://github.com/apache/kafka/pull/8534 - Added additional synchronization and increased timeouts to handle flakiness - Added some pre-cautionary retries when trying to obtain lag map *More detailed description of your change,

[GitHub] [kafka] vinothchandar commented on issue #8462: KAFKA-9846: Filter active tasks for running state in KafkaStreams#allLocalStorePartitionLags()

vinothchandar commented on issue #8462: URL: https://github.com/apache/kafka/pull/8462#issuecomment-617931148 Opened a simple backport here #8534.. We can focus on that for fixing the test flakiness itself. This is an autom

[GitHub] [kafka] abbccdda commented on a change in pull request #8495: MINOR: downgrade test should wait for ISR rejoin between rolls

abbccdda commented on a change in pull request #8495: URL: https://github.com/apache/kafka/pull/8495#discussion_r413199411 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -26,10 +27,12 @@ from kafkatest.version import LATEST_0_9, LATEST_0_10, LATEST_0_10_0, L

[GitHub] [kafka] guozhangwang commented on issue #8462: KAFKA-9846: Filter active tasks for running state in KafkaStreams#allLocalStorePartitionLags()

guozhangwang commented on issue #8462: URL: https://github.com/apache/kafka/pull/8462#issuecomment-617948771 > Opened a simple backport here #8534.. We can focus on that for fixing the test flakiness itself. Sounds good, thanks! -

[GitHub] [kafka] guozhangwang commented on issue #8534: KAFKA-9512: Backport Flaky Test LagFetchIntegrationTest.shouldFetchLagsDuringRestoration

guozhangwang commented on issue #8534: URL: https://github.com/apache/kafka/pull/8534#issuecomment-617949190 @vinothchandar this PR is still in the `work in progress` state, is that ready for review and merge? This is an aut

[GitHub] [kafka] vinothchandar commented on issue #8534: KAFKA-9512: Backport Flaky Test LagFetchIntegrationTest.shouldFetchLagsDuringRestoration

vinothchandar commented on issue #8534: URL: https://github.com/apache/kafka/pull/8534#issuecomment-617950145 Will remove the draft status in a little bit.. Running the test again on 2.5 branch many times to confirm flakiness is gone... It will be ready for review and merge then

[GitHub] [kafka] lbradstreet commented on a change in pull request #8495: MINOR: downgrade test should wait for ISR rejoin between rolls

lbradstreet commented on a change in pull request #8495: URL: https://github.com/apache/kafka/pull/8495#discussion_r413216403 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -26,10 +27,12 @@ from kafkatest.version import LATEST_0_9, LATEST_0_10, LATEST_0_10_0,

[jira] [Commented] (KAFKA-9903) kafka ShutdownableThread judge thread isRuning status has some bug

[ https://issues.apache.org/jira/browse/KAFKA-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089926#comment-17089926 ] Guozhang Wang commented on KAFKA-9903: -- Hello Shilin, Thanks for the report, and I

[jira] [Commented] (KAFKA-9903) kafka ShutdownableThread judge thread isRuning status has some bug

[ https://issues.apache.org/jira/browse/KAFKA-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089936#comment-17089936 ] shilin Lu commented on KAFKA-9903: -- ok, i think your advice is make sense. i will create

[GitHub] [kafka] lushilin opened a new pull request #8535: KAFKA-9903

lushilin opened a new pull request #8535: URL: https://github.com/apache/kafka/pull/8535 ShutdownComplete will countdown in the finally block when thread shutdown due to an error, and in this case thread is not running. So isRunning logic should check isShutdownInitiated and isShutdownCo

[GitHub] [kafka] lushilin commented on issue #8535: KAFKA-9903

lushilin commented on issue #8535: URL: https://github.com/apache/kafka/pull/8535#issuecomment-617984080 @guozhangwang @ijuma @junrao PTAL, thanks This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (KAFKA-9903) kafka ShutdownableThread judge thread isRuning status has some bug

[ https://issues.apache.org/jira/browse/KAFKA-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089973#comment-17089973 ] shilin Lu commented on KAFKA-9903: -- pull request: [https://github.com/apache/kafka/pull/

[GitHub] [kafka] hachikuji commented on a change in pull request #8445: KAFKA-9823: Remember the sent generation for the coordinator request

hachikuji commented on a change in pull request #8445: URL: https://github.com/apache/kafka/pull/8445#discussion_r413250770 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java ## @@ -466,24 +477,193 @@ public void testS

[GitHub] [kafka] rhauch opened a new pull request #8536: KAFKA-9883: Add better error message when REST API forwards a request and leader is not known

rhauch opened a new pull request #8536: URL: https://github.com/apache/kafka/pull/8536 When the Connect worker forwards a REST API request to the leader, it might get back a `RequestTargetException` that suggests the worker should forward the request to a different worker. This can happen

[jira] [Assigned] (KAFKA-9883) Connect request to restart task can result in IllegalArgumentError: "uriTemplate" parameter is null

[ https://issues.apache.org/jira/browse/KAFKA-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reassigned KAFKA-9883: Assignee: Randall Hauch > Connect request to restart task can result in IllegalArgumentErr

[GitHub] [kafka] vinothchandar commented on issue #8534: KAFKA-9512: Backport Flaky Test LagFetchIntegrationTest.shouldFetchLagsDuringRestoration

vinothchandar commented on issue #8534: URL: https://github.com/apache/kafka/pull/8534#issuecomment-618019176 Ran for over 600 times without issues. @guozhangwang ready. This is an automated message from the Apache Git Servi

[GitHub] [kafka] cmccabe commented on issue #8482: KAFKA-9863: update the deprecated --zookeeper option in the documentation into --bootstrap-server

cmccabe commented on issue #8482: URL: https://github.com/apache/kafka/pull/8482#issuecomment-618027980 LGTM. Thanks, @showuon , @rondagostino This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] apovzner commented on a change in pull request #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

apovzner commented on a change in pull request #8509: URL: https://github.com/apache/kafka/pull/8509#discussion_r413337972 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -1553,6 +1552,179 @@ class KafkaApisTest { assertEquals(Errors.INVALID_R

[GitHub] [kafka] apovzner commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

apovzner commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-618044488 @dajac and @hachikuji thanks for your comments, I addressed them. This is an automated message from the Apache Git Servi

[GitHub] [kafka] guozhangwang commented on issue #8530: KAFKA-9388: Refactor integration tests to always use different application ids

guozhangwang commented on issue #8530: URL: https://github.com/apache/kafka/pull/8530#issuecomment-618044905 The Jenkins failures are due to known flaky tests, I'm going to merge the PR as is. This is an automated message fr

[jira] [Resolved] (KAFKA-9388) Flaky Test StandbyTaskCreationIntegrationTest.shouldCreateStandByTasksForMaterializedAndOptimizedSourceTables

[ https://issues.apache.org/jira/browse/KAFKA-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9388. -- Fix Version/s: 2.6.0 Assignee: Guozhang Wang Resolution: Fixed > Flaky Test >

[jira] [Commented] (KAFKA-8369) Generate an immutable Map view for generated messages with a map key

[ https://issues.apache.org/jira/browse/KAFKA-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090056#comment-17090056 ] Colin McCabe commented on KAFKA-8369: - So, the collection is the way it is to avoid h

[jira] [Created] (KAFKA-9905) The equals functions for generated classes should compare all fields

Colin McCabe created KAFKA-9905: --- Summary: The equals functions for generated classes should compare all fields Key: KAFKA-9905 URL: https://issues.apache.org/jira/browse/KAFKA-9905 Project: Kafka

[GitHub] [kafka] hachikuji commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

hachikuji commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-618070266 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] hachikuji commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

hachikuji commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-618070328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mjsax commented on issue #8504: KAFKA-9298: reuse mapped stream error in joins

mjsax commented on issue #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-618073161 > Ideally, the fix should be to generate a repartition topic name each time to avoid such issues. But IMHO that ship has already sailed because by introducing a new name generation will ca

[GitHub] [kafka] mjsax commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

mjsax commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r413380852 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -989,16 +994,18 @@ private void to(final TopicNameExtra

[GitHub] [kafka] guozhangwang commented on a change in pull request #8326: KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol

guozhangwang commented on a change in pull request #8326: URL: https://github.com/apache/kafka/pull/8326#discussion_r413374355 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java ## @@ -17,157 +17,109 @@ package org.apache.kafka

[GitHub] [kafka] C0urante commented on issue #8069: KAFKA-9374: Make connector interactions asynchronous

C0urante commented on issue #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-618097440 @ncliang I've made some updates to the PR and rebased on the latest trunk; would you be willing to do another pass? Thi

[GitHub] [kafka] guozhangwang commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

guozhangwang commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r413417021 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -498,6 +498,104 @@ public void validateOffsetsIfNee

[GitHub] [kafka] guozhangwang commented on issue #8534: KAFKA-9512: Backport Flaky Test LagFetchIntegrationTest.shouldFetchLagsDuringRestoration

guozhangwang commented on issue #8534: URL: https://github.com/apache/kafka/pull/8534#issuecomment-618104185 Thanks @vinothchandar !! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] junrao commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

junrao commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r413436495 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,7 +1068,9 @@ class KafkaController(val config: KafkaConfig, val

[jira] [Updated] (KAFKA-9906) Is bytesSinceLastIndexEntry updated correctly when LogSegment.append() is called ?

[ https://issues.apache.org/jira/browse/KAFKA-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Zhang updated KAFKA-9906: --- Summary: Is bytesSinceLastIndexEntry updated correctly when LogSegment.append() is called ? (was: Is

[jira] [Created] (KAFKA-9906) Is bytesSinceLastIndexEntry updated correct when LogSegment.append() is called ?

Xiang Zhang created KAFKA-9906: -- Summary: Is bytesSinceLastIndexEntry updated correct when LogSegment.append() is called ? Key: KAFKA-9906 URL: https://issues.apache.org/jira/browse/KAFKA-9906 Project: K

[jira] [Updated] (KAFKA-9906) Is bytesSinceLastIndexEntry updated correct when LogSegment.append() is called ?

[ https://issues.apache.org/jira/browse/KAFKA-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Zhang updated KAFKA-9906: --- Description: I was reading code in LogSegment.scala and I found the code in  > Is bytesSinceLastIndex

[jira] [Updated] (KAFKA-9906) Is bytesSinceLastIndexEntry updated correctly when LogSegment.append() is called ?

[ https://issues.apache.org/jira/browse/KAFKA-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Zhang updated KAFKA-9906: --- Description: I was reading code in LogSegment.scala and I found the code below:   {code:java} def ap

[jira] [Updated] (KAFKA-9906) Is bytesSinceLastIndexEntry updated correctly in LogSegment.append()?

[ https://issues.apache.org/jira/browse/KAFKA-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Zhang updated KAFKA-9906: --- Summary: Is bytesSinceLastIndexEntry updated correctly in LogSegment.append()? (was: Is bytesSinceLa

[GitHub] [kafka] abbccdda commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

abbccdda commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r413442881 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -498,6 +498,104 @@ public void validateOffsetsIfNeeded(

[jira] [Updated] (KAFKA-9857) Failed to build image ducker-ak-openjdk-8 on arm

[ https://issues.apache.org/jira/browse/KAFKA-9857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jiamei xie updated KAFKA-9857: -- Component/s: core > Failed to build image ducker-ak-openjdk-8 on arm >

[jira] [Updated] (KAFKA-9857) Failed to build image ducker-ak-openjdk-8 on arm

[ https://issues.apache.org/jira/browse/KAFKA-9857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jiamei xie updated KAFKA-9857: -- Component/s: build > Failed to build image ducker-ak-openjdk-8 on arm > ---

[jira] [Updated] (KAFKA-9804) Extract ConsumerPerform config into one file

[ https://issues.apache.org/jira/browse/KAFKA-9804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jiamei xie updated KAFKA-9804: -- Component/s: tools > Extract ConsumerPerform config into one file > ---

[GitHub] [kafka] jiameixie commented on issue #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm

jiameixie commented on issue #8489: URL: https://github.com/apache/kafka/pull/8489#issuecomment-618132157 @guozhangwang @ijuma @junrao PTAL, thanks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] abbccdda commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

abbccdda commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r413468323 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsForLeaderEpochClient.java ## @@ -85,10 +85,6 @@ protected OffsetFor

[GitHub] [kafka] hachikuji commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

hachikuji commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-618147106 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] abbccdda commented on a change in pull request #8326: KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol

abbccdda commented on a change in pull request #8326: URL: https://github.com/apache/kafka/pull/8326#discussion_r413471840 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java ## @@ -17,157 +17,109 @@ package org.apache.kafka.com

[GitHub] [kafka] abbccdda commented on a change in pull request #8326: KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol

abbccdda commented on a change in pull request #8326: URL: https://github.com/apache/kafka/pull/8326#discussion_r413473580 ## File path: core/src/test/scala/unit/kafka/server/AddPartitionsToTxnRequestServerTest.scala ## @@ -27,9 +27,9 @@ import org.junit.{Before, Test} impo

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r391363596 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java ## @@ -132,47 +130,74 @@ private static String

[GitHub] [kafka] chia7712 commented on issue #5935: KAFKA-7665: Replace BaseConsumerRecord with ConsumerRecord in MM

chia7712 commented on issue #5935: URL: https://github.com/apache/kafka/pull/5935#issuecomment-618162318 @huxihx Are you still working on this? I'd like to complete both of KIP and this PR :) This is an automated message fro

[GitHub] [kafka] jiameixie commented on issue #8529: KAFKA-9901:Fix streams_broker_bounce_test error

jiameixie commented on issue #8529: URL: https://github.com/apache/kafka/pull/8529#issuecomment-618169833 @guozhangwang @ijuma @junrao PTAL, thanks This is an automated message from the Apache Git Service. To respond to the m

[jira] [Updated] (KAFKA-9893) Configurable TCP connection timeout and improve the initial metadata fetch

[ https://issues.apache.org/jira/browse/KAFKA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9893: - Summary: Configurable TCP connection timeout and improve the initial metadata fetch (was: Configurable T

[GitHub] [kafka] jiameixie commented on issue #8446: KAFKA-9804:Extract consumer configs out of PerfConfig

jiameixie commented on issue #8446: URL: https://github.com/apache/kafka/pull/8446#issuecomment-618169937 @guozhangwang @ijuma @junrao PTAL, thanks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r413499718 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -263,17 +267,20 @@ public boolean startConnector(

[jira] [Updated] (KAFKA-9804) Extract ConsumerPerform config into one file

[ https://issues.apache.org/jira/browse/KAFKA-9804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jiamei xie updated KAFKA-9804: -- Labels: newbie pull-request-available (was: ) > Extract ConsumerPerform config into one file > ---

[jira] [Updated] (KAFKA-9893) Configurable TCP connection timeout and improve the initial metadata fetch

[ https://issues.apache.org/jira/browse/KAFKA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9893: - Description: This issue has two parts: # Support TCP connection timeout described in KIP-601 # Currentl

[GitHub] [kafka] ijuma commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

ijuma commented on issue #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-618192475 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (KAFKA-9907) Switch default build to Scala 2.13

Ismael Juma created KAFKA-9907: -- Summary: Switch default build to Scala 2.13 Key: KAFKA-9907 URL: https://issues.apache.org/jira/browse/KAFKA-9907 Project: Kafka Issue Type: Improvement

  1   2   >