Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-04-06 Thread via GitHub
chia7712 commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r2030143366 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -470,8 +470,8 @@ public FetchDataInfo read(long startOffset, return maybe

Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-04-05 Thread via GitHub
showuon commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r2030056754 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -470,8 +470,8 @@ public FetchDataInfo read(long startOffset, return maybeH

Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-04-05 Thread via GitHub
ijuma commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r2029928276 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -470,8 +470,8 @@ public FetchDataInfo read(long startOffset, return maybeHan

Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r2029925512 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -470,8 +470,8 @@ public FetchDataInfo read(long startOffset, return maybe

Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-01-08 Thread via GitHub
chia7712 commented on PR #18393: URL: https://github.com/apache/kafka/pull/18393#issuecomment-2577135890 > Does this need to be backported or is it only a bug in trunk? I have backported it to 4.0 (see https://github.com/chia7712/kafka/commit/41e4743be9700947ecff2cf13ed49edf5d4b364f)

Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-01-07 Thread via GitHub
gongxuanzhang commented on PR #18393: URL: https://github.com/apache/kafka/pull/18393#issuecomment-2576816644 > Does this need to be backported or is it only a bug in trunk? This class create from 2024-9-17. The part about strings from 2024-10-24. I looked at the tag time. I don't t

Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-01-07 Thread via GitHub
gongxuanzhang commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r1906512137 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -358,7 +358,7 @@ public void deleteEmptyDir() { */ public List del

Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-01-07 Thread via GitHub
ijuma commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r1906386696 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -358,7 +358,7 @@ public void deleteEmptyDir() { */ public List deleteAllSe

Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-01-07 Thread via GitHub
ijuma commented on PR #18393: URL: https://github.com/apache/kafka/pull/18393#issuecomment-2576674989 Does this need to be backported or is it only a bug in trunk? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-01-06 Thread via GitHub
chia7712 merged PR #18393: URL: https://github.com/apache/kafka/pull/18393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache