Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-05-10 Thread via GitHub
chia7712 merged PR #19482: URL: https://github.com/apache/kafka/pull/19482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-05-10 Thread via GitHub
apalan60 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2868724157 > @apalan60 thanks for this patch. Is it possible to replace `ProducerStateManagerConfig` by `TransactionLogConfig`? In the `DynamicProducerStateManagerConfig` we create `TransactionLogC

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-05-05 Thread via GitHub
chia7712 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2850108793 @apalan60 thanks for this patch. Is it possible to replace `ProducerStateManagerConfig` by `TransactionLogConfig`? In the `DynamicProducerStateManagerConfig` we create `TransactionLogCon

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2818434084 @apalan60 could you please rebase code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-21 Thread via GitHub
apalan60 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2818448633 @chia7712 Thanks for the kind reminder, merging the trunk now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-21 Thread via GitHub
chia7712 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2817853834 the timeout is traced by https://issues.apache.org/jira/browse/KAFKA-19180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-19 Thread via GitHub
apalan60 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2816743752 I’m encountering a Gradle task timeout. I’ll rerun CI without any changes to see if it passes. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-18 Thread via GitHub
FrankYang0529 commented on code in PR #19482: URL: https://github.com/apache/kafka/pull/19482#discussion_r2050316442 ## transaction-coordinator/src/test/java/org/apache/kafka/coordinator/transaction/TransactionLogConfigTest.java: ## @@ -92,12 +92,13 @@ void ShouldGetDynamicValue

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-17 Thread via GitHub
apalan60 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2813994916 I’ve updated the unit test to reflect the internal behavior of ```TransactionLogConfig```: it's now immutable after construction and no longer hold ```AbstractConfig```. The upda

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-16 Thread via GitHub
apalan60 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2811318094 > @apalan60: The failed tests are related to the patch. Please fix them. Sorry, I missed this --fixing now and will update soon, thanks for the reminder. -- This is an automated