chia7712 merged PR #19775:
URL: https://github.com/apache/kafka/pull/19775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
sjhajharia commented on PR #19775:
URL: https://github.com/apache/kafka/pull/19775#issuecomment-2906407518
No worries @chia7712
This PR is ready for review.
TIA!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on PR #19775:
URL: https://github.com/apache/kafka/pull/19775#issuecomment-2904044925
> I had to revert the change suggested by you. The reason is that the method
is used in a different way by the test in that class. Removal led to test
failures.
you are right, Ple
sjhajharia commented on PR #19775:
URL: https://github.com/apache/kafka/pull/19775#issuecomment-2904011707
Hey @chia7712 ,
I had to revert the change suggested by you. The reason is that the method
is used in a different way by the test in that class. Removal led to test
failures.
--
sjhajharia commented on code in PR #19775:
URL: https://github.com/apache/kafka/pull/19775#discussion_r2103728787
##
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -34,7 +33,7 @@
public class ClusterTes
chia7712 commented on code in PR #19775:
URL: https://github.com/apache/kafka/pull/19775#discussion_r2103362597
##
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -34,7 +33,7 @@
public class ClusterTestE
sjhajharia commented on PR #19775:
URL: https://github.com/apache/kafka/pull/19775#issuecomment-2898518442
Thanks @m1a2st for the review,
I have addressed the suggestions.
Requesting a re-review!
--
This is an automated message from the Apache Git Service.
To respond to the message,
m1a2st commented on code in PR #19775:
URL: https://github.com/apache/kafka/pull/19775#discussion_r2100149965
##
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/junit/ClusterTestExtensions.java:
##
@@ -268,7 +268,7 @@ private List
processClusterTestIn
