chia7712 merged PR #19791:
URL: https://github.com/apache/kafka/pull/19791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
sjhajharia commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-3024101807
Hey @chia7712
Gentle reminder!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
sjhajharia commented on code in PR #19791:
URL: https://github.com/apache/kafka/pull/19791#discussion_r2160087650
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/core/TestPurgatoryPerformance.java:
##
@@ -313,7 +313,7 @@ public long next() {
}
public voi
chia7712 commented on code in PR #19791:
URL: https://github.com/apache/kafka/pull/19791#discussion_r2160075084
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/core/TestPurgatoryPerformance.java:
##
@@ -313,7 +313,7 @@ public long next() {
}
public void
sjhajharia commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2961221581
Gentle reminder @chia7712 @frankvicky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
sjhajharia commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2944068063
Gentle reminder
@frankvicky @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sjhajharia commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2924430980
Hey @frankvicky
If you can pls have a look at this PR too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sjhajharia commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2915729538
cc: @frankvicky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sjhajharia commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2909416974
Hey @m1a2st
I have updated the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
m1a2st commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2908408215
Please resolve the conflict, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Yunyung commented on code in PR #19791:
URL: https://github.com/apache/kafka/pull/19791#discussion_r2106118300
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -189,7 +187,7 @@ private Optional rackId(int memberIndex) {
p
m1a2st commented on code in PR #19791:
URL: https://github.com/apache/kafka/pull/19791#discussion_r2106058418
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -189,7 +187,7 @@ private Optional rackId(int memberIndex) {
pr
sjhajharia commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2905251231
Thanks @Yunyung for the review. I have addressed the comment.
PTAL when possible!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Yunyung commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2904765961
Thanks for the PR. Could you also do this cleanup?
Collections.unmodifiableMap -> Map.copyOf
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
14 matches
Mail list logo
