chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1591866899
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -306,11 +300,16 @@ public Builder setPerBrokerProperties(Map> perBroke
return this;
}
chia7712 commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2097528853
As #15766 gets merged now, could you please fix the build error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
johnnychhsu commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2096037200
updated and `./gradlew clean core:test --tests ClusterTestExtensionsTest
--tests ClusterConfigTest` passed
--
This is an automated message from the Apache Git Service.
To respond to
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590943709
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -44,4 +44,5 @@
String listener() default "";
MetadataVersion metadataVersion() default
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590940053
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -83,6 +81,7 @@ private ClusterConfig(Type type, int brokers, int
controllers, int disksPerBroke
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590457683
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -44,4 +44,5 @@
String listener() default "";
MetadataVersion metadataVersion() default Me
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590273427
##
core/src/test/java/kafka/test/annotation/ClusterTestDefaults.java:
##
@@ -42,4 +42,5 @@
boolean autoStart() default true;
// Set default server propert
johnnychhsu commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2094744565
updated and `./gradlew clean core:test --tests ClusterTestExtensionsTest
--tests ClusterConfigTest` passed
--
This is an automated message from the Apache Git Service.
To respond t
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590270528
##
core/src/test/java/kafka/test/annotation/ClusterConfigDisplayTag.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590270405
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -152,6 +154,9 @@ public MetadataVersion metadataVersion() {
public Map> perBrokerOverrideProperties() {
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590267358
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -152,6 +154,9 @@ public MetadataVersion metadataVersion() {
public Map> perBrokerOverrideProperties(
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590267137
##
core/src/test/java/kafka/test/annotation/ClusterConfigDisplayTag.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590266910
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -44,4 +44,5 @@
String listener() default "";
MetadataVersion metadataVersion() default
13 matches
Mail list logo