chia7712 merged PR #19776:
URL: https://github.com/apache/kafka/pull/19776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2156558942
##
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##
@@ -900,42 +901,32 @@ class GroupCoordinatorBaseRequestTest(cluster:
ClusterInstanc
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2156544696
##
core/src/test/scala/unit/kafka/server/DescribeQuorumRequestTest.scala:
##
@@ -91,11 +92,8 @@ class DescribeQuorumRequestTest(cluster: ClusterInstance) {
)(
Revi
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2153459442
##
core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala:
##
@@ -556,9 +557,11 @@ class ClientQuotasRequestTest(cluster: ClusterInstance) {
private
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2152714907
##
server-common/src/test/java/org/apache/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2151869849
##
server-common/src/test/java/org/apache/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2151869849
##
server-common/src/test/java/org/apache/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2151866540
##
server-common/src/test/java/org/apache/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2150020977
##
server-common/src/test/java/org/apache/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
jim0987795064 commented on PR #19776:
URL: https://github.com/apache/kafka/pull/19776#issuecomment-2976377683
Hello, @chia7712 @m1a2st I've addressed the issues mentioned above.
Could you please review these? Many Thanks!
--
This is an automated message from the Apache Git Service.
To r
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2147492786
##
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##
@@ -900,42 +901,32 @@ class GroupCoordinatorBaseRequestTest(cluster:
ClusterInstanc
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2134796089
##
server-common/src/test/java/org/apache/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
chia7712 commented on PR #19776:
URL: https://github.com/apache/kafka/pull/19776#issuecomment-2943635600
@jim0987795064 please check the failed tests or sync the trunk to trigger QA
again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jim0987795064 commented on PR #19776:
URL: https://github.com/apache/kafka/pull/19776#issuecomment-2937201446
Hello, @chia7712 @m1a2st I've addressed the issues mentioned above.
Could you please review these?
--
This is an automated message from the Apache Git Service.
To respond to the
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2116362068
##
core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIntegrationTest.scala:
##
@@ -205,11 +205,12 @@ class ProducerIntegrationTest {
.setP
jim0987795064 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2114114865
##
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala:
##
@@ -41,12 +42,18 @@ abstract class AbstractApiVersionsRequestTest(cluster:
Clus
jim0987795064 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2114114865
##
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala:
##
@@ -41,12 +42,18 @@ abstract class AbstractApiVersionsRequestTest(cluster:
Clus
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2113744859
##
server-common/src/test/java/integration/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jim0987795064 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2105787616
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2494,8 +2494,7 @@ void handleResponse(AbstractResponse abstractResponse) {
m1a2st commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2105755254
##
core/src/test/java/integration/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2104779153
##
core/src/test/java/integration/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
jim0987795064 commented on PR #19776:
URL: https://github.com/apache/kafka/pull/19776#issuecomment-2903368139
> @jim0987795064 please fix the conflicts
Hello @chia7712
Thank you, I have addressed this comment.
--
This is an automated message from the Apache Git Service.
To respo
chia7712 commented on PR #19776:
URL: https://github.com/apache/kafka/pull/19776#issuecomment-2902504720
@jim0987795064 please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
23 matches
Mail list logo
