lucasbru merged PR #19425:
URL: https://github.com/apache/kafka/pull/19425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on PR #19425:
URL: https://github.com/apache/kafka/pull/19425#issuecomment-2792673278
Thanks for the comments @FrankYang0529, addressed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lucasbru commented on code in PR #19425:
URL: https://github.com/apache/kafka/pull/19425#discussion_r2037278831
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java:
##
@@ -140,6 +140,19 @@ public EmbeddedKafkaCluster(fi
FrankYang0529 commented on code in PR #19425:
URL: https://github.com/apache/kafka/pull/19425#discussion_r2037183291
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java:
##
@@ -140,6 +140,19 @@ public EmbeddedKafkaClust
lucasbru commented on code in PR #19425:
URL: https://github.com/apache/kafka/pull/19425#discussion_r2036636589
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java:
##
@@ -140,6 +140,13 @@ public EmbeddedKafkaCluster(fi
lucasbru commented on PR #19425:
URL: https://github.com/apache/kafka/pull/19425#issuecomment-2791744850
@bbejeck Thanks for the review. Comment addressed, ready for rereview.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
lucasbru commented on PR #19425:
URL: https://github.com/apache/kafka/pull/19425#issuecomment-2789605788
PTAL @aliehsaeedii
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
bbejeck commented on code in PR #19425:
URL: https://github.com/apache/kafka/pull/19425#discussion_r2035488915
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java:
##
@@ -140,6 +140,13 @@ public EmbeddedKafkaCluster(fin
