Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

chia7712 merged PR #19393: URL: https://github.com/apache/kafka/pull/19393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

chia7712 commented on PR #19393: URL: https://github.com/apache/kafka/pull/19393#issuecomment-2849178967 @m1a2st please update PR according to the fix of #19578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

chia7712 commented on code in PR #19393: URL: https://github.com/apache/kafka/pull/19393#discussion_r2061407189 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1634,7 +1635,8 @@ public Map beginningOffsets(Collection par * @param part

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

m1a2st commented on PR #19393: URL: https://github.com/apache/kafka/pull/19393#issuecomment-2820100352 Thanks for @chia7712 comments, addressed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

chia7712 commented on PR #19393: URL: https://github.com/apache/kafka/pull/19393#issuecomment-2817223866 @m1a2st could you please update docs for `offsetsForTimes` as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

m1a2st commented on PR #19393: URL: https://github.com/apache/kafka/pull/19393#issuecomment-2816679715 Thanks for @kirktrue comments, addressed all :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

kirktrue commented on code in PR #19393: URL: https://github.com/apache/kafka/pull/19393#discussion_r2049779243 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1634,7 +1635,8 @@ public Map beginningOffsets(Collection par * @param part

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

m1a2st commented on PR #19393: URL: https://github.com/apache/kafka/pull/19393#issuecomment-2783697038 Hello @kirktrue, if you have free cycle, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

m1a2st commented on code in PR #19393: URL: https://github.com/apache/kafka/pull/19393#discussion_r2031149018 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1658,7 +1660,8 @@ public Map beginningOffsets(Collection par * @see #seekToE

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

Yunyung commented on code in PR #19393: URL: https://github.com/apache/kafka/pull/19393#discussion_r2030586173 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1658,7 +1660,8 @@ public Map beginningOffsets(Collection par * @see #seekTo

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

Yunyung commented on code in PR #19393: URL: https://github.com/apache/kafka/pull/19393#discussion_r2030586173 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1658,7 +1660,8 @@ public Map beginningOffsets(Collection par * @see #seekTo

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

Yunyung commented on code in PR #19393: URL: https://github.com/apache/kafka/pull/19393#discussion_r2030586173 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1658,7 +1660,8 @@ public Map beginningOffsets(Collection par * @see #seekTo