chia7712 merged PR #19581:
URL: https://github.com/apache/kafka/pull/19581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2078236499
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1073,146 @@ public void testUnsupportedCompress() {
});
junrao commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2078047010
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1073,146 @@ public void testUnsupportedCompress() {
});
}
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2077506551
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1073,148 @@ public void testUnsupportedCompress() {
});
chia7712 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2077497018
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1073,148 @@ public void testUnsupportedCompress() {
});
}
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2077487454
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1073,146 @@ public void testUnsupportedCompress() {
});
junrao commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2076340154
##
clients/src/main/java/org/apache/kafka/common/record/Records.java:
##
@@ -90,4 +91,18 @@ public interface Records extends TransferableRecords {
* @return The re
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2076118431
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1073,148 @@ public void testUnsupportedCompress() {
});
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2076116846
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -209,16 +209,13 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2076116567
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1073,148 @@ public void testUnsupportedCompress() {
});
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2076108970
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##
@@ -312,7 +312,7 @@ public ByteBuffer buffer() {
* @return A sliced buffer o
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2076108970
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##
@@ -312,7 +312,7 @@ public ByteBuffer buffer() {
* @return A sliced buffer o
junrao commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2075993932
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1073,148 @@ public void testUnsupportedCompress() {
});
}
chia7712 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2075897444
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -209,16 +209,13 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition tp) {
apoorvmittal10 commented on PR #19581:
URL: https://github.com/apache/kafka/pull/19581#issuecomment-2854788346
Thanks @AndrewJSchofield and @junrao for review, sorry I got occupied with
other PR reviews and issues so couldn't reply earlier. I have addressed the
comments now.
--
This is a
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2075606254
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1072,149 @@ public void testUnsupportedCompress() {
});
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2075600196
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1072,149 @@ public void testUnsupportedCompress() {
});
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2075597778
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1072,149 @@ public void testUnsupportedCompress() {
});
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2075586874
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1068,6 +1072,149 @@ public void testUnsupportedCompress() {
});
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2075586071
##
clients/src/main/java/org/apache/kafka/common/record/Records.java:
##
@@ -90,4 +91,18 @@ public interface Records extends TransferableRecords {
* @retur
apoorvmittal10 commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2075585304
##
clients/src/main/java/org/apache/kafka/common/record/Records.java:
##
@@ -90,4 +91,18 @@ public interface Records extends TransferableRecords {
* @retur
AndrewJSchofield commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2069906803
##
clients/src/main/java/org/apache/kafka/common/record/Records.java:
##
@@ -90,4 +91,18 @@ public interface Records extends TransferableRecords {
* @ret
junrao commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2069620518
##
clients/src/main/java/org/apache/kafka/common/record/Records.java:
##
@@ -90,4 +91,18 @@ public interface Records extends TransferableRecords {
* @return The re
AndrewJSchofield commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2063755306
##
clients/src/main/java/org/apache/kafka/common/record/Records.java:
##
@@ -90,4 +91,18 @@ public interface Records extends TransferableRecords {
* @ret
24 matches
Mail list logo
