Re: [PR] KAFKA-18648: Make `records` in `FetchResponse` nullable again [kafka]

2025-03-08 Thread via GitHub
ijuma commented on PR #19131: URL: https://github.com/apache/kafka/pull/19131#issuecomment-2704563232 Cherry-picked to 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-18648: Make `records` in `FetchResponse` nullable again [kafka]

2025-03-06 Thread via GitHub
ijuma commented on PR #19131: URL: https://github.com/apache/kafka/pull/19131#issuecomment-2704667744 @chia7712 To close the loop, I filed https://issues.apache.org/jira/browse/KAFKA-18934 and https://issues.apache.org/jira/browse/KAFKA-18935 -- This is an automated message from the Apac

Re: [PR] KAFKA-18648: Make `records` in `FetchResponse` nullable again [kafka]

2025-03-06 Thread via GitHub
ijuma merged PR #19131: URL: https://github.com/apache/kafka/pull/19131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18648: Make `records` in `FetchResponse` nullable again [kafka]

2025-03-06 Thread via GitHub
ijuma commented on PR #19131: URL: https://github.com/apache/kafka/pull/19131#issuecomment-2703088499 @chia7712 I'm confident the code doesn't do that right now given the constraint we had until this PR. I think we should also ensure we don't regress, but perhaps that can be done for 4.1 in

Re: [PR] KAFKA-18648: Make `records` in `FetchResponse` nullable again [kafka]

2025-03-05 Thread via GitHub
ijuma commented on PR #19131: URL: https://github.com/apache/kafka/pull/19131#issuecomment-2703049893 I'll update the KIP once this is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the