junrao merged PR #18804:
URL: https://github.com/apache/kafka/pull/18804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
apoorvmittal10 commented on PR #18804:
URL: https://github.com/apache/kafka/pull/18804#issuecomment-2678724852
@junrao The build is green for latest run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
apoorvmittal10 commented on PR #18804:
URL: https://github.com/apache/kafka/pull/18804#issuecomment-2675485219
> @apoorvmittal10 : Thanks for the updated PR. The code LGTM. Are the failed
tests related to this PR?
Thanks @junrao. The build passes on Java 17 and unrelated failure on Ja
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1965447465
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +186,67 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1965415311
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +186,67 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition
junrao commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1964112656
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +186,67 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition tp) {
apoorvmittal10 commented on PR #18804:
URL: https://github.com/apache/kafka/pull/18804#issuecomment-2656284002
@junrao Please if I can get a re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
apoorvmittal10 commented on PR #18804:
URL: https://github.com/apache/kafka/pull/18804#issuecomment-2649349794
Hi @junrao, can you please re-review the simplified solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1949965157
##
server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTestUtils.java:
##
@@ -74,4 +87,62 @@ public static void validateRotatedMapEquals(
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1949964577
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1949964577
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1949962995
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition
junrao commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1947187901
##
server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTestUtils.java:
##
@@ -74,4 +87,62 @@ public static void validateRotatedMapEquals(
ass
apoorvmittal10 commented on PR #18804:
URL: https://github.com/apache/kafka/pull/18804#issuecomment-2643452122
Thanks for the review @junrao, I have addressed and replied to the comments.
I also have one doubt regrding MemoryRecords, please if you can guide.
--
This is an automated messag
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1946842921
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1946814224
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1946804279
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -678,6 +680,9 @@ public ShareAcquiredRecords acquire(
for (Map.Entry entry : sub
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1946814224
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1946811181
##
core/src/test/java/kafka/server/share/ShareFetchUtilsTest.java:
##
@@ -449,4 +468,202 @@ tp0, new FetchPartitionData(Errors.OFFSET_OUT_OF_RANGE,
0L, 0L,
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1946804279
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -678,6 +680,9 @@ public ShareAcquiredRecords acquire(
for (Map.Entry entry : sub
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1946804279
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -678,6 +680,9 @@ public ShareAcquiredRecords acquire(
for (Map.Entry entry : sub
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1946804279
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -678,6 +680,9 @@ public ShareAcquiredRecords acquire(
for (Map.Entry entry : sub
junrao commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1945434837
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition tp) {
apoorvmittal10 commented on PR #18804:
URL: https://github.com/apache/kafka/pull/18804#issuecomment-2641317917
> Carried out an initial pass 😊, thank you, this has been an interesting
read!
Thanks for taking a look, indeed it's an intersesting change to optimize the
transferred bytes
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1945592660
##
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##
@@ -1186,6 +1185,50 @@ public void
testAcquireWithMultipleBatchesAndMaxFetchRecords() {
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1945591501
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition
clolov commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1944774713
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition tp) {
Copilot commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1941832078
##
server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTestUtils.java:
##
@@ -74,4 +87,74 @@ public static void validateRotatedMapEquals(
as
apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1941829163
##
server/src/main/java/org/apache/kafka/server/share/fetch/ShareAcquiredRecords.java:
##
@@ -60,13 +68,20 @@ public int count() {
return count;
}
Copilot commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1941816234
##
server/src/main/java/org/apache/kafka/server/share/fetch/ShareAcquiredRecords.java:
##
@@ -60,13 +68,20 @@ public int count() {
return count;
}
+
30 matches
Mail list logo
