Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2025-01-03 Thread via GitHub
swikarpat closed pull request #18066: KAFKA-18111 Add kafka logo URL: https://github.com/apache/kafka/pull/18066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-25 Thread via GitHub
swikarpat commented on PR #18066: URL: https://github.com/apache/kafka/pull/18066#issuecomment-2561962646 > Hi @swikarpat > > Thanks for the patch. > > This logo doesn’t feel very balanced. Have you considered using the following version? > > > > https://kafka.a

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
frankvicky commented on PR #18066: URL: https://github.com/apache/kafka/pull/18066#issuecomment-2530266949 Hi @swikarpat This logo doesn’t feel very balanced. Have you considered using the following version? https://kafka.apache.org/trademark -- This is an automated message fro

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876354093 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: @cadonna I

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876354093 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: @cadonna I

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876354093 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: @cadonna I

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876354093 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: @cadonna I

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876354093 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: @cadonna I

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876354093 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: @cadonna I

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
cadonna commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876238774 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: @swikarpat

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876049098 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: The logo i

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876049098 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: The logo i

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876049098 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: The logo i

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876049098 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: The logo i

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-09 Thread via GitHub
cadonna commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1875628074 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: Could you gi

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-06 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1873751724 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: Hi @cadonn

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-06 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1873751724 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: @cadonna T

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-06 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1873751724 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: That is st

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-06 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1873751724 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: That is st

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-06 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1873751724 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: That is st

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-05 Thread via GitHub
cadonna commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1872737109 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: @swikarpat I

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-05 Thread via GitHub
swikarpat commented on PR #18066: URL: https://github.com/apache/kafka/pull/18066#issuecomment-2521526940 > Hey there @swikarpat. Is there a reason this was reopened and not continued in https://github.com/apache/kafka/pull/18027? It seems like some of the context/comments were in that PR.

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-05 Thread via GitHub
jolshan commented on PR #18066: URL: https://github.com/apache/kafka/pull/18066#issuecomment-2521492011 Hey there @swikarpat. Is there a reason this was reopened and not continued in https://github.com/apache/kafka/pull/18027? It seems like some of the context/comments were in that PR. --

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-05 Thread via GitHub
swikarpat commented on PR #18066: URL: https://github.com/apache/kafka/pull/18066#issuecomment-2521098572 @gharris1727 @mimaison @TaiJuWu I have added License information in .svg file and all checks passed. Please merge to trunk -- This is an automated message from the Apache Git Serv