Re: [PR] KAFKA-16894: Define features to enable share groups [kafka]

2025-03-31 Thread via GitHub
AndrewJSchofield commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2022235254 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -132,7 +143,7 @@ public enum MetadataVersion { * Think carefull

Re: [PR] KAFKA-16894: Define features to enable share groups [kafka]

2025-03-31 Thread via GitHub
AndrewJSchofield commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2022234245 ## server-common/src/main/java/org/apache/kafka/server/common/ShareVersion.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] KAFKA-16894: Define features to enable share groups [kafka]

2025-03-31 Thread via GitHub
junrao commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2021846262 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -132,7 +143,7 @@ public enum MetadataVersion { * Think carefully before y

Re: [PR] KAFKA-16894: Define features to enable share groups [kafka]

2025-03-26 Thread via GitHub
dajac commented on PR #19293: URL: https://github.com/apache/kafka/pull/19293#issuecomment-2755031196 @AndrewJSchofield I would like to better understand how `group.version=2` will be used. Could you elaborate a bit more on what we will gate with it? -- This is an automated message from