github-actions[bot] closed pull request #19199: KAFKA-16616: refactor mergeWith
and updatePartitionLeadership
URL: https://github.com/apache/kafka/pull/19199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #19199:
URL: https://github.com/apache/kafka/pull/19199#issuecomment-3153187766
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #19199:
URL: https://github.com/apache/kafka/pull/19199#issuecomment-3040738868
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
kirktrue commented on PR #19199:
URL: https://github.com/apache/kafka/pull/19199#issuecomment-2767702063
@lorcanj—Looking at the [test history of
`CooperativeConsumerCoordinatorTest.testOutdatedCoordinatorAssignment()`](https://develocity.apache.org/scans/tests?search.relativeStartTime=P28D&
lorcanj commented on code in PR #19199:
URL: https://github.com/apache/kafka/pull/19199#discussion_r2004919701
##
clients/src/main/java/org/apache/kafka/clients/MetadataSnapshot.java:
##
@@ -173,12 +173,15 @@ MetadataSnapshot mergeWith(String newClusterId,
Map newMeta
lorcanj commented on code in PR #19199:
URL: https://github.com/apache/kafka/pull/19199#discussion_r2004905258
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -422,21 +423,17 @@ public synchronized Set
updatePartitionLeadership(Map
lorcanj commented on PR #19199:
URL: https://github.com/apache/kafka/pull/19199#issuecomment-2770394927
Hi @kirktrue, I believe the test was failing due a falky test which some
people had noticed was causing the test to outright fail too,
[KAFKA-15900](https://issues.apache.org/jira/browse/
lorcanj commented on PR #19199:
URL: https://github.com/apache/kafka/pull/19199#issuecomment-2745095132
Hi @kirktrue, I've made the updates as per your comments.
There is a failing test testOutdatedCoordinatorAssignment under JUnit Java
17 (Flaky) that's failed twice. I don't seem to
lorcanj commented on code in PR #19199:
URL: https://github.com/apache/kafka/pull/19199#discussion_r2006364925
##
clients/src/main/java/org/apache/kafka/clients/MetadataSnapshot.java:
##
@@ -173,12 +173,15 @@ MetadataSnapshot mergeWith(String newClusterId,
Map newMeta
lorcanj commented on code in PR #19199:
URL: https://github.com/apache/kafka/pull/19199#discussion_r2004922608
##
clients/src/main/java/org/apache/kafka/clients/MetadataSnapshot.java:
##
@@ -173,12 +173,15 @@ MetadataSnapshot mergeWith(String newClusterId,
Map newMeta
kirktrue commented on code in PR #19199:
URL: https://github.com/apache/kafka/pull/19199#discussion_r2002151201
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -422,21 +423,17 @@ public synchronized Set
updatePartitionLeadership(Map newMetadataByPartition
11 matches
Mail list logo
