github-actions[bot] closed pull request #15417: KAFKA-14588 ConfigCommand
rewritten to java
URL: https://github.com/apache/kafka/pull/15417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-actions[bot] commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2849835009
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2780176535
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2309238666
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
chia7712 commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2133076712
> Are we stop this PR until 3.8 or until all dependencies will be moved out
of core?
short answer: Yes!
Personally, it would be great to address the final purpose - all in j
nizhikov commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2133054563
> We can postpone rewriting for a while (especially, 3.8.0 is going to be
released)
@chia7712 @mimaison
Can you, please, clarify.
Are we stop this PR until 3.8 or until
chia7712 commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2124375972
> Waiting for your feedback regarding
https://github.com/apache/kafka/pull/15848
will take a look today :)
--
This is an automated message from the Apache Git Service.
To respon
nizhikov commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2124348649
@chia7712 Got it.
Waiting for your feedback regarding #15848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2124336401
> If we postpone rewriting ConfigCommand itself, please, tell me, if we
going to proceed with the https://github.com/apache/kafka/pull/15848 and merge
remaining ConfigCommand tests?
nizhikov commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2124050183
@chia7712
@mimaison
AFAIK we are going to rewrite all the kafka code to java eventually.
We want to split core to the several modules, also.
It seems like this PR con
chia7712 commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2123057138
It seems to me rewriting tools-related tests code has a good reason: we are
increase the test coverage for those tests (for example: #15840). Those new
test-purposed java code are easy t
nizhikov commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2123020489
Hello @mimaison
Thanks for the feedback.
> The goal is to break down the core module
Yes, I understand this.
> we should focus on resolving these issues first
mimaison commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2122992609
> I suggest to proceed and merge java version of command in core module.
This can be helpful while re-implementing these classes but I'm not sure we
want to merge that to trunk.
13 matches
Mail list logo
