chia7712 commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2052025917
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java:
##
@@ -0,0 +1,650 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
wernerdv commented on PR #19387:
URL: https://github.com/apache/kafka/pull/19387#issuecomment-2797455575
@mimaison @junrao Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
junrao merged PR #19387:
URL: https://github.com/apache/kafka/pull/19387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2038343739
##
storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java:
##
@@ -0,0 +1,762 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2038343035
##
storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java:
##
@@ -0,0 +1,770 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2032560885
##
storage/src/main/java/org/apache/kafka/storage/internals/log/CleanedTransactionMetadata.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundatio
wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2034777548
##
storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java:
##
@@ -0,0 +1,762 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
junrao commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2037829585
##
storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java:
##
@@ -0,0 +1,762 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mimaison commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2031926411
##
build.gradle:
##
@@ -3737,6 +3737,7 @@ project(':connect:mirror') {
testImplementation project(':core')
testImplementation project(':test-common:test-comm
wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2035323732
##
storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java:
##
@@ -0,0 +1,762 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
mimaison commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2035011565
##
storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java:
##
@@ -0,0 +1,762 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2034641102
##
storage/src/main/java/org/apache/kafka/storage/internals/log/CleanedTransactionMetadata.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundatio
mimaison commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2032797613
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java:
##
@@ -0,0 +1,652 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2032661374
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java:
##
@@ -0,0 +1,652 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2032650604
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1384,7 +1385,7 @@ class LogManager(logDirs: Seq[File],
val deletableLogs = {
if (cleaner != null)
wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2032648047
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1407,7 +1408,7 @@ class LogManager(logDirs: Seq[File],
}
} finally {
if (cleaner != null)
wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2032487977
##
build.gradle:
##
@@ -3737,6 +3737,7 @@ project(':connect:mirror') {
testImplementation project(':core')
testImplementation project(':test-common:test-comm
chia7712 commented on PR #19387:
URL: https://github.com/apache/kafka/pull/19387#issuecomment-2781729703
@wernerdv could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
18 matches
Mail list logo