Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #17888: URL: https://github.com/apache/kafka/pull/17888#issuecomment-2665984323 @fonsdant I apologize, and while we typically prioritize the oldest PR, we are currently preparing for the 4.0.0 release, which may make us a little impolite :( If you have other

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #17888: URL: https://github.com/apache/kafka/pull/17888#issuecomment-2666055242 @fonsdant thanks for you. I'm going to close this PR/jira -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
chia7712 closed pull request #17888: KAFKA-12622: Automate LICENSE file validation URL: https://github.com/apache/kafka/pull/17888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
fonsdant commented on PR #17888: URL: https://github.com/apache/kafka/pull/17888#issuecomment-2666006113 No problem, @chia7712, @dajac! I really asked because I'm relatively new to the community. I've been involved since August of last year and some things are still new to me. Thanks for yo

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
dajac commented on PR #17888: URL: https://github.com/apache/kafka/pull/17888#issuecomment-2665986342 @fonsdant My bad. I was not aware your PR. I looked into the license as part of the release process and automated it right away. Sorry for this. -- This is an automated message from the A

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
fonsdant commented on PR #17888: URL: https://github.com/apache/kafka/pull/17888#issuecomment-2665964346 @chia7712, oh, I see... 😕 In this case, I'm not sure. I thought that, in case of duplication, we should consider the oldest task/PR, right? In other words, KAFKA-12622/#17888. I s

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #17888: URL: https://github.com/apache/kafka/pull/17888#issuecomment-2665811990 @fonsdant thanks for this script but I guess it is duplicate to #18931? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-01-24 Thread via GitHub
divijvaidya commented on PR #17888: URL: https://github.com/apache/kafka/pull/17888#issuecomment-2612420137 @dajac do you want to try this one out during release process of 4.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub