Re: [PR] [WIP] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-04-10 Thread via GitHub
frankvicky commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2036681668 ## tools/src/test/java/org/apache/kafka/tools/ResetIntegrationTest.java: ## @@ -256,9 +255,8 @@ public void testResetWhenLongSessionTimeoutConfiguredWithForceOption

Re: [PR] [WIP] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-04-10 Thread via GitHub
frankvicky commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2036675899 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1205,45 +1200,9 @@ private Optional removeStreamThread(final long timeoutMs) throws Time

Re: [PR] [WIP] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-04-10 Thread via GitHub
frankvicky commented on PR #19400: URL: https://github.com/apache/kafka/pull/19400#issuecomment-2791810133 Hi @ableegoldman Please take a look when you have a free moment. I have some questions since I'm not familiar with the stream module. Please bear with me if the code looks like