Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-12 Thread via GitHub
jsancio commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2085061929 ## raft/src/main/java/org/apache/kafka/raft/RaftUtil.java: ## @@ -755,4 +756,18 @@ static boolean hasValidTopicPartition(DescribeQuorumRequestData data, TopicParti

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-12 Thread via GitHub
jsancio commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2082461965 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState state, long currentTimeM

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-10 Thread via GitHub
ahuang98 commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2082083752 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState state, long currentTime

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-09 Thread via GitHub
ahuang98 commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r208255 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -4569,6 +4574,55 @@ public void testObserverFetchWithNoLocalId(boolean withKip853Rpc) thro

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-09 Thread via GitHub
ahuang98 commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2082481731 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -4569,6 +4574,55 @@ public void testObserverFetchWithNoLocalId(boolean withKip853Rpc) thro

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-09 Thread via GitHub
jsancio commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2082461965 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState state, long currentTimeM

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-09 Thread via GitHub
Yunyung commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2082456060 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -4569,6 +4574,55 @@ public void testObserverFetchWithNoLocalId(boolean withKip853Rpc) throw

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-09 Thread via GitHub
TaiJuWu commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2082277116 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState state, long currentTimeM

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-09 Thread via GitHub
ahuang98 commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2082083752 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState state, long currentTime

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-09 Thread via GitHub
ahuang98 commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2082035897 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -4569,6 +4574,55 @@ public void testObserverFetchWithNoLocalId(boolean withKip853Rpc) thro

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-09 Thread via GitHub
Yunyung commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2081198851 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -4569,6 +4574,55 @@ public void testObserverFetchWithNoLocalId(boolean withKip853Rpc) throw

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-08 Thread via GitHub
TaiJuWu commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2080885590 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState state, long currentTimeM