TaiJuWu closed pull request #16083: MINOR:Improve ConsumerRebalanceListener doc
URL: https://github.com/apache/kafka/pull/16083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
TaiJuWu commented on PR #16083:
URL: https://github.com/apache/kafka/pull/16083#issuecomment-2319304919
> Thanks for the PR @TaiJuWu!
>
> The changes appear to be grammatical, and the bulk of them are an
improvement. I don't see how it can hurt to be a little more precise, where
poss
kirktrue commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1735416616
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -144,9 +144,9 @@ public interface ConsumerRebalanceListener {
voi
chia7712 commented on PR #16083:
URL: https://github.com/apache/kafka/pull/16083#issuecomment-2169107085
@TaiJuWu any updates? I do love those docs improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
AndrewJSchofield commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1620630034
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is h
TaiJuWu commented on PR #16083:
URL: https://github.com/apache/kafka/pull/16083#issuecomment-2139394200
Hi @AndrewJSchofield @lianetm
Thanks for your review and I address your comments, please review again.
--
This is an automated message from the Apache Git Service.
To respond to the m
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1617261952
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -119,15 +119,15 @@
public interface ConsumerRebalanceListener {
AndrewJSchofield commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616865033
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is h
TaiJuWu commented on PR #16083:
URL: https://github.com/apache/kafka/pull/16083#issuecomment-2133955005
@lianetm Thanks for your comments, I have addressed your comment. Please
review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
TaiJuWu commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616331569
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kaf
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616124179
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -119,15 +119,15 @@
public interface ConsumerRebalanceListener {
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616099696
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kaf
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616090879
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kaf
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616082089
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kaf
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616077491
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kaf
TaiJuWu commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1615418058
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kaf
chia7712 commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1615204659
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Ka
17 matches
Mail list logo
