chia7712 merged PR #19314:
URL: https://github.com/apache/kafka/pull/19314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mjsax commented on PR #19314:
URL: https://github.com/apache/kafka/pull/19314#issuecomment-2784956048
This one is still small enough. -- No reason to split it. -- There is no
fixed rule. It always depends always on the ticket, but I usually try to keep
it below 500 LOC -- if larger, there s
lorcanj commented on PR #19314:
URL: https://github.com/apache/kafka/pull/19314#issuecomment-2784070246
Hi @mjsax, I noticed you commented on a ticket that I raised which mentioned
not combining too many changes into 1 PR. Could you advise whether it would be
advisable to split this up into
github-actions[bot] commented on PR #19314:
URL: https://github.com/apache/kafka/pull/19314#issuecomment-2781923254
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
lorcanj commented on PR #19314:
URL: https://github.com/apache/kafka/pull/19314#issuecomment-2764667714
I've got one more commit of these changes to push but will wait for a review
first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
lorcanj opened a new pull request, #19314:
URL: https://github.com/apache/kafka/pull/19314
Java provides a specialised Map where Enums are the keys, which can provide
some performance improvements.
https://docs.oracle.com/javase/8/docs/api/java/util/EnumMap.html
I have updated
