Re: [PR] MINOR: remove unnecessary logging [kafka]

2024-02-22 Thread via GitHub
jolshan commented on PR #15396: URL: https://github.com/apache/kafka/pull/15396#issuecomment-1960482583 fyi: https://github.com/apache/kafka/pull/15422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] MINOR: remove unnecessary logging [kafka]

2024-02-22 Thread via GitHub
jolshan commented on PR #15396: URL: https://github.com/apache/kafka/pull/15396#issuecomment-1960438257 Hey this broke the following tests that expect this log message: ``` RocksDBSegmentedBytesStoreTest. shouldLogAndMeasureExpiredRecords[org.apache.kafka.streams.state.internals.Sessio

Re: [PR] MINOR: remove unnecessary logging [kafka]

2024-02-21 Thread via GitHub
mjsax merged PR #15396: URL: https://github.com/apache/kafka/pull/15396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: remove unnecessary logging [kafka]

2024-02-20 Thread via GitHub
wcarlson5 commented on code in PR #15396: URL: https://github.com/apache/kafka/pull/15396#discussion_r1496604182 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java: ## @@ -264,7 +264,6 @@ public void put(final Bytes key,

Re: [PR] MINOR: remove unnecessary logging [kafka]

2024-02-20 Thread via GitHub
mjsax commented on code in PR #15396: URL: https://github.com/apache/kafka/pull/15396#discussion_r1496379447 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java: ## @@ -264,7 +264,6 @@ public void put(final Bytes key,

Re: [PR] MINOR: remove unnecessary logging [kafka]

2024-02-20 Thread via GitHub
kpatelatwork commented on code in PR #15396: URL: https://github.com/apache/kafka/pull/15396#discussion_r1496373291 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java: ## @@ -264,7 +264,6 @@ public void put(final Bytes key,

[PR] MINOR: remove unnecessary logging [kafka]

2024-02-20 Thread via GitHub
mjsax opened a new pull request, #15396: URL: https://github.com/apache/kafka/pull/15396 We already record dropping record via metrics and logging at WARN level is too noise. This PR removes the unnecessary logging. -- This is an automated message from the Apache Git Service. To respo