Re: [PR] MINOR: remove get prefix for internal IQ methods [kafka]

2024-08-27 Thread via GitHub
mjsax commented on code in PR #16954: URL: https://github.com/apache/kafka/pull/16954#discussion_r1733869564 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java: ## @@ -246,7 +246,7 @@ default boolean commitRequested() { // IQ related methods

Re: [PR] MINOR: remove get prefix for internal IQ methods [kafka]

2024-08-25 Thread via GitHub
chia7712 merged PR #16954: URL: https://github.com/apache/kafka/pull/16954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: remove get prefix for internal IQ methods [kafka]

2024-08-25 Thread via GitHub
chia7712 commented on PR #16954: URL: https://github.com/apache/kafka/pull/16954#issuecomment-2309029491 I open https://issues.apache.org/jira/browse/KAFKA-17420 to trace `StreamThreadTest.tearDown`, and others are known flaky. -- This is an automated message from the Apache Git Service.

Re: [PR] MINOR: remove get prefix for internal IQ methods [kafka]

2024-08-25 Thread via GitHub
mjsax commented on code in PR #16954: URL: https://github.com/apache/kafka/pull/16954#discussion_r1730404855 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java: ## @@ -246,7 +246,7 @@ default boolean commitRequested() { // IQ related methods

Re: [PR] MINOR: remove get prefix for internal IQ methods [kafka]

2024-08-25 Thread via GitHub
mjsax commented on code in PR #16954: URL: https://github.com/apache/kafka/pull/16954#discussion_r1730404618 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java: ## @@ -206,29 +206,29 @@ public synchronized Collection getAllMetadataFo

Re: [PR] MINOR: remove get prefix for internal IQ methods [kafka]

2024-08-25 Thread via GitHub
chia7712 commented on code in PR #16954: URL: https://github.com/apache/kafka/pull/16954#discussion_r1730329818 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java: ## @@ -206,29 +206,29 @@ public synchronized Collection getAllMetadat

[PR] MINOR: remove get prefix for internal IQ methods [kafka]

2024-08-21 Thread via GitHub
mjsax opened a new pull request, #16954: URL: https://github.com/apache/kafka/pull/16954 Follow up PR to https://github.com/apache/kafka/pull/16722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to