Re: [PR] MINOR: prevent exception from HdrHistogram [kafka]

2025-01-30 Thread via GitHub
jeffkbkim commented on PR #18674: URL: https://github.com/apache/kafka/pull/18674#issuecomment-2624809498 picked to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] MINOR: prevent exception from HdrHistogram [kafka]

2025-01-29 Thread via GitHub
jeffkbkim merged PR #18674: URL: https://github.com/apache/kafka/pull/18674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

Re: [PR] MINOR: prevent exception from HdrHistogram [kafka]

2025-01-29 Thread via GitHub
chia7712 commented on PR #18674: URL: https://github.com/apache/kafka/pull/18674#issuecomment-2622117662 #18735 is handling the flaky `testAdminClientApisAuthenticationFailure` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] MINOR: prevent exception from HdrHistogram [kafka]

2025-01-28 Thread via GitHub
jeffkbkim commented on PR #18674: URL: https://github.com/apache/kafka/pull/18674#issuecomment-2620332279 @dajac @chia7712 this is ready for another round of review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] MINOR: prevent exception from HdrHistogram [kafka]

2025-01-23 Thread via GitHub
chia7712 commented on code in PR #18674: URL: https://github.com/apache/kafka/pull/18674#discussion_r1927289096 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/KafkaMetricHistogram.java: ## @@ -125,6 +127,6 @@ public List stats() { @Overrid

Re: [PR] MINOR: prevent exception from HdrHistogram [kafka]

2025-01-22 Thread via GitHub
dajac commented on code in PR #18674: URL: https://github.com/apache/kafka/pull/18674#discussion_r1926425181 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/KafkaMetricHistogram.java: ## @@ -125,6 +127,6 @@ public List stats() { @Override

[PR] MINOR: prevent exception from HdrHistogram [kafka]

2025-01-22 Thread via GitHub
jeffkbkim opened a new pull request, #18674: URL: https://github.com/apache/kafka/pull/18674 HdrHistogram can throw an exception if the recorded value is greater than a configured limit. Expand the ceiling from per-metric to all invocations. Using [existing test](https://github.com/apache/