Re: [PR] MINOR: leverage preProcessParsedConfig within AbstractConfig [kafka]

2025-04-05 Thread via GitHub
m1a2st commented on code in PR #19259: URL: https://github.com/apache/kafka/pull/19259#discussion_r2007871072 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -114,6 +114,15 @@ public void testOriginalsWithPrefix() { assertEquals(ex

Re: [PR] MINOR: leverage preProcessParsedConfig within AbstractConfig [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on PR #19259: URL: https://github.com/apache/kafka/pull/19259#issuecomment-2742476082 This is a kind of big fix, so please add a test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: leverage preProcessParsedConfig within AbstractConfig [kafka]

2025-04-04 Thread via GitHub
chia7712 merged PR #19259: URL: https://github.com/apache/kafka/pull/19259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: leverage preProcessParsedConfig within AbstractConfig [kafka]

2025-03-22 Thread via GitHub
TaiJuWu commented on code in PR #19259: URL: https://github.com/apache/kafka/pull/19259#discussion_r2008840279 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -114,6 +114,15 @@ public void testOriginalsWithPrefix() { assertEquals(e

Re: [PR] MINOR: leverage preProcessParsedConfig within AbstractConfig [kafka]

2025-03-22 Thread via GitHub
TaiJuWu commented on code in PR #19259: URL: https://github.com/apache/kafka/pull/19259#discussion_r2008840279 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -114,6 +114,15 @@ public void testOriginalsWithPrefix() { assertEquals(e

Re: [PR] MINOR: leverage preProcessParsedConfig within AbstractConfig [kafka]

2025-03-21 Thread via GitHub
TaiJuWu commented on PR #19259: URL: https://github.com/apache/kafka/pull/19259#issuecomment-2743495248 > This is a kind of big fix, so please add a test Done. Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[PR] MINOR: leverage preProcessParsedConfig within AbstractConfig [kafka]

2025-03-20 Thread via GitHub
TaiJuWu opened a new pull request, #19259: URL: https://github.com/apache/kafka/pull/19259 In past, we have `AbstractConfig#preProcessParsedConfig` but did not use its return value This PR fix such issue. -- This is an automated message from the Apache Git Service. To respond to th