Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-10 Thread via GitHub
mjsax commented on PR #18760: URL: https://github.com/apache/kafka/pull/18760#issuecomment-2649137966 Thanks for highlighting this issue (and thanks for the PR to fix it). The build for this PR did not surface this issue (otherwise we would not have merged it). I agree, that it might be goo

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-10 Thread via GitHub
chia7712 commented on PR #18760: URL: https://github.com/apache/kafka/pull/18760#issuecomment-2648206457 This PR is great and has given me an idea for improving our CI process. This PR introduce a java doc error, and hence QA does not run `streams:test`. ``` 2025-02-05T05:09:25.4

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-06 Thread via GitHub
mjsax merged PR #18760: URL: https://github.com/apache/kafka/pull/18760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-04 Thread via GitHub
mjsax commented on code in PR #18760: URL: https://github.com/apache/kafka/pull/18760#discussion_r1942246889 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -758,185 +756,118 @@ KStream flatMapValues(final ValueMapperWithKey - * The created to

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-04 Thread via GitHub
mjsax commented on code in PR #18760: URL: https://github.com/apache/kafka/pull/18760#discussion_r1942246261 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -758,185 +756,118 @@ KStream flatMapValues(final ValueMapperWithKey - * The created to

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-04 Thread via GitHub
lucasbru commented on code in PR #18760: URL: https://github.com/apache/kafka/pull/18760#discussion_r1940875377 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -758,185 +756,118 @@ KStream flatMapValues(final ValueMapperWithKey - * The created

[PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-01-30 Thread via GitHub
mjsax opened a new pull request, #18760: URL: https://github.com/apache/kafka/pull/18760 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail