Re: [PR] MINOR: Update dependencies [kafka]

2025-01-30 Thread via GitHub
divijvaidya closed pull request #18648: MINOR: Update dependencies URL: https://github.com/apache/kafka/pull/18648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] MINOR: Update dependencies [kafka]

2025-01-20 Thread via GitHub
divijvaidya opened a new pull request, #18648: URL: https://github.com/apache/kafka/pull/18648 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] MINOR: Update dependencies [kafka]

2024-03-19 Thread via GitHub
jlprat commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-2007053721 I generated the wrapper the way `gradle` recommends (`./gradlew wrapper --gradle-version latest`). I would leave it the way gradle generates it -- This is an automated message from the A

Re: [PR] MINOR: Update dependencies [kafka]

2024-03-19 Thread via GitHub
pasharik commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-2007048822 There is a version of gradle wrapper in our [gradlew](https://github.com/apache/kafka/blob/trunk/gradlew#L119) file: ``` https://raw.githubusercontent.com/gradle/gradle/v8.5.0/

Re: [PR] MINOR: Update dependencies [kafka]

2024-03-19 Thread via GitHub
pasharik commented on code in PR #15404: URL: https://github.com/apache/kafka/pull/15404#discussion_r1530262197 ## gradle/dependencies.gradle: ## @@ -100,10 +100,10 @@ versions += [ commonsCli: "1.4", commonsValidator: "1.7", dropwizardMetrics: "4.1.12.1", - gradle: "8

Re: [PR] MINOR: Update dependencies [kafka]

2024-03-18 Thread via GitHub
jlprat commented on code in PR #15404: URL: https://github.com/apache/kafka/pull/15404#discussion_r1528355399 ## gradle/dependencies.gradle: ## @@ -100,10 +100,10 @@ versions += [ commonsCli: "1.4", commonsValidator: "1.7", dropwizardMetrics: "4.1.12.1", - gradle: "8.5

Re: [PR] MINOR: Update dependencies [kafka]

2024-03-18 Thread via GitHub
jlprat commented on code in PR #15404: URL: https://github.com/apache/kafka/pull/15404#discussion_r1528029938 ## gradle/dependencies.gradle: ## @@ -100,10 +100,10 @@ versions += [ commonsCli: "1.4", commonsValidator: "1.7", dropwizardMetrics: "4.1.12.1", - gradle: "8.5

Re: [PR] MINOR: Update dependencies [kafka]

2024-03-15 Thread via GitHub
ijuma commented on code in PR #15404: URL: https://github.com/apache/kafka/pull/15404#discussion_r1526810480 ## gradle/dependencies.gradle: ## @@ -100,10 +100,10 @@ versions += [ commonsCli: "1.4", commonsValidator: "1.7", dropwizardMetrics: "4.1.12.1", - gradle: "8.5"

Re: [PR] MINOR: Update dependencies [kafka]

2024-03-15 Thread via GitHub
pasharik commented on code in PR #15404: URL: https://github.com/apache/kafka/pull/15404#discussion_r1526739190 ## gradle/dependencies.gradle: ## @@ -100,10 +100,10 @@ versions += [ commonsCli: "1.4", commonsValidator: "1.7", dropwizardMetrics: "4.1.12.1", - gradle: "8

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-22 Thread via GitHub
divijvaidya commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-1959312473 > Regarding a backport to the 3.6 branch, Gradle version over there is 8.2.1, it's a bit of a jump I believe. Ok, no worries. Let's keep it limited to 3.7.x. We can always revis

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-22 Thread via GitHub
jlprat commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-1959267158 Regarding a backport to the `3.6` branch, Gradle version over there is `8.2.1`, it's a bit of a jump I believe. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-22 Thread via GitHub
jlprat commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-1959250699 Backported to `3.7` branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-22 Thread via GitHub
jlprat merged PR #15404: URL: https://github.com/apache/kafka/pull/15404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-22 Thread via GitHub
jlprat commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-1958953132 @divijvaidya as you already partially reviewed this, do you mind finishing the review? Also to which versions did you think this should be backported? -- This is an automated message

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-21 Thread via GitHub
jlprat commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-1956458474 Rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-21 Thread via GitHub
divijvaidya commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-1956451482 It must have been fixed by https://github.com/apache/kafka/commit/cc49fc76564b15f2111801faf62341aaf01c4d8c Perhaps a rebase from trunk should help. -- This is an automated messa

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-21 Thread via GitHub
jlprat commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-1956432277 I would say `trunk` build is broken again. I'll investigate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-21 Thread via GitHub
jlprat commented on code in PR #15404: URL: https://github.com/apache/kafka/pull/15404#discussion_r1497350416 ## gradlew: ## @@ -215,11 +215,11 @@ fi # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. DEFAULT_JVM_OPT

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-21 Thread via GitHub
divijvaidya commented on code in PR #15404: URL: https://github.com/apache/kafka/pull/15404#discussion_r1497338394 ## gradlew: ## @@ -215,11 +215,11 @@ fi # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. DEFAULT_JV

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-21 Thread via GitHub
divijvaidya commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-1956402963 Please update license of jackson here - https://github.com/apache/kafka/blob/cc49fc76564b15f2111801faf62341aaf01c4d8c/LICENSE-binary#L219 -- This is an automated message from the Ap

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-21 Thread via GitHub
jlprat commented on code in PR #15404: URL: https://github.com/apache/kafka/pull/15404#discussion_r1497178970 ## gradlew: ## Review Comment: Changes in this file are auto-generated -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] MINOR: Update dependencies [kafka]

2024-02-21 Thread via GitHub
jlprat opened a new pull request, #15404: URL: https://github.com/apache/kafka/pull/15404 Updates minor versions for our dependencies and build tool - Jackson from 2.16.0 to 2.16.1 - JUnit from 5.10.0 to 5.10.2 https://junit.org/junit5/docs/5.10.2/release-notes/ and https://junit.