Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

mjsax commented on PR #18336: URL: https://github.com/apache/kafka/pull/18336#issuecomment-2573979621 Merged to `trunk` and cherry-picked to `4.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

mjsax merged PR #18336: URL: https://github.com/apache/kafka/pull/18336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

AndrewJSchofield commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1904383009 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -276,7 +279,10 @@ * * * Note: The committed offset should always be

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

mjsax commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1902062099 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -266,8 +270,7 @@ * for (ConsumerRecord record : pa

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

mjsax commented on PR #18336: URL: https://github.com/apache/kafka/pull/18336#issuecomment-2569658303 Thanks for all the input. Pushed an updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

chia7712 commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1901429698 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -266,8 +270,7 @@ * for (ConsumerRecord record :

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

mjsax commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1901289940 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -266,8 +270,7 @@ * for (ConsumerRecord record : pa

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

mjsax commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1901289940 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -266,8 +270,7 @@ * for (ConsumerRecord record : pa

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

mjsax commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1901289940 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -266,8 +270,7 @@ * for (ConsumerRecord record : pa

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

mjsax commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1901288600 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -70,8 +70,12 @@ * Offsets and Consumer Position * Kafka maintains a numerical off

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

lianetm commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1900988248 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -70,8 +70,12 @@ * Offsets and Consumer Position * Kafka maintains a numerical o

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

chia7712 commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1900398750 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -266,8 +270,7 @@ * for (ConsumerRecord record :

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

AndrewJSchofield commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1898872562 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -70,8 +70,12 @@ * Offsets and Consumer Position * Kafka maintains a nu

[PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

mjsax opened a new pull request, #18336: URL: https://github.com/apache/kafka/pull/18336 The consumer/producer JavaDocs still contain instruction for naively computing the offset to be committed. This PR updates the JavaDocs with regard to the improvements of KIP-1094. -- This is an au