Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2024-01-18 Thread via GitHub
C0urante merged PR #12290: URL: https://github.com/apache/kafka/pull/12290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1450789672 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -434,23 +484,31 @@ public Block(Map props) { publ

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-15 Thread via GitHub
C0urante commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1428127814 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425906944 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425906944 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425904694 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425879028 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -139,7 +141,8 @@ public void setup() throws Exception {

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
C0urante commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425798851 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -139,7 +141,8 @@ public void setup() throws Exception { pu

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425661550 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -350,13 +353,16 @@ private void assertRequestTimesOut(String

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425661185 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -139,7 +141,8 @@ public void setup() throws Exception {

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
C0urante commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425475580 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-12 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1424413335 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -350,13 +353,16 @@ private void assertRequestTimesOut(String