Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-07-30 Thread via GitHub
github-actions[bot] closed pull request #19250: MINOR: Specify 2.1 as the minimum broker version for clients URL: https://github.com/apache/kafka/pull/19250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-07-30 Thread via GitHub
github-actions[bot] commented on PR #19250: URL: https://github.com/apache/kafka/pull/19250#issuecomment-3138473853 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-06-30 Thread via GitHub
github-actions[bot] commented on PR #19250: URL: https://github.com/apache/kafka/pull/19250#issuecomment-3021653514 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-04-05 Thread via GitHub
ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r200354 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tran

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-04-05 Thread via GitHub
jolshan commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2007965891 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tr

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-04-04 Thread via GitHub
jolshan commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006621799 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tr

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-31 Thread via GitHub
lianetm commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2021118860 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -61,9 +61,9 @@ * The consumer is not thread-safe. See Multi-threaded Processing f

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-31 Thread via GitHub
lianetm commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2021118860 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -61,9 +61,9 @@ * The consumer is not thread-safe. See Multi-threaded Processing f

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2016352250 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -61,9 +61,9 @@ * The consumer is not thread-safe. See Multi-threaded Processing

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006668652 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tran

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
jolshan commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006623313 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tr

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
jolshan commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006621799 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tr

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
jolshan commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006572583 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -636,8 +632,6 @@ private TransactionManager configureTransactionState(ProducerConf

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
junrao commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2006572003 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tra

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2005653399 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tran

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-20 Thread via GitHub
lianetm commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2005638869 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -61,9 +61,9 @@ * The consumer is not thread-safe. See Multi-threaded Processing f

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-19 Thread via GitHub
ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2004795817 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -61,9 +61,9 @@ * The consumer is not thread-safe. See Multi-threaded Processing for

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-19 Thread via GitHub
ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2004796009 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -138,14 +138,14 @@ * the batch.size config. Making this larger can result in more

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-19 Thread via GitHub
ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2004796472 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -157,24 +157,19 @@ * their ProducerRecord into bytes. You can use the included {@l

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-19 Thread via GitHub
ijuma commented on PR #19250: URL: https://github.com/apache/kafka/pull/19250#issuecomment-2739125388 This needs to be cherry-picked to the 4.0 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-19 Thread via GitHub
ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2004798260 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -636,8 +632,6 @@ private TransactionManager configureTransactionState(ProducerConfig

[PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-19 Thread via GitHub
ijuma opened a new pull request, #19250: URL: https://github.com/apache/kafka/pull/19250 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail