Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-04-05 Thread via GitHub
lianetm commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2016344814 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
dajac merged PR #19281: URL: https://github.com/apache/kafka/pull/19281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
dajac commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2015985621 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections im

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
dajac commented on PR #19281: URL: https://github.com/apache/kafka/pull/19281#issuecomment-2757464241 > nit: It appears `ShareGroupHeartbeatRequestTest` also requires cleanup. However, it's acceptable to leave it as is - or we can fix it in the follow-up Removed it and few others rela

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2015826951 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
dajac commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2015820533 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections im

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-26 Thread via GitHub
lianetm commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2014959782 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections

[PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-25 Thread via GitHub
dajac opened a new pull request, #19281: URL: https://github.com/apache/kafka/pull/19281 This patch applies a few cleanups to uniformize how group coordinator's integration tests are setup. -- This is an automated message from the Apache Git Service. To respond to the message, please