Re: [PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv commented on PR #19446: URL: https://github.com/apache/kafka/pull/19446#issuecomment-2840827675 @mjsax @frankvicky @FrankYang0529 Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

mjsax commented on PR #19446: URL: https://github.com/apache/kafka/pull/19446#issuecomment-2840451662 Thanks for the PR. Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

mjsax merged PR #19446: URL: https://github.com/apache/kafka/pull/19446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065795964 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java: ## @@ -509,24 +507,30 @@ public void shouldReturnSameMetricI

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065737402 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/CopartitionedTopicsEnforcerTest.java: ## @@ -124,8 +124,8 @@ public void shouldThrowAnExceptionI

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065760741 ## streams/src/test/java/org/apache/kafka/streams/tests/StreamsNamedRepartitionTest.java: ## @@ -55,7 +55,7 @@ public static void main(final String[] args) throws Exce

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065760741 ## streams/src/test/java/org/apache/kafka/streams/tests/StreamsNamedRepartitionTest.java: ## @@ -55,7 +55,7 @@ public static void main(final String[] args) throws Exce

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065737402 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/CopartitionedTopicsEnforcerTest.java: ## @@ -124,8 +124,8 @@ public void shouldThrowAnExceptionI

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

frankvicky commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065252762 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/CopartitionedTopicsEnforcerTest.java: ## @@ -124,8 +124,8 @@ public void shouldThrowAnExceptio

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

mjsax commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2064434824 ## streams/src/test/java/org/apache/kafka/streams/tests/StreamsNamedRepartitionTest.java: ## @@ -55,7 +55,7 @@ public static void main(final String[] args) throws Excepti

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

mjsax commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2064426826 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java: ## @@ -509,24 +507,30 @@ public void shouldReturnSameMetricIfAl

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

mjsax commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2064413275 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/CopartitionedTopicsEnforcerTest.java: ## @@ -124,8 +124,8 @@ public void shouldThrowAnExceptionIfRe

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv commented on PR #19446: URL: https://github.com/apache/kafka/pull/19446#issuecomment-2832013699 @mjsax @cadonna @lucasbru Hello, please take a look at this when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv commented on PR #19446: URL: https://github.com/apache/kafka/pull/19446#issuecomment-2817293293 @chia7712 @frankvicky Could you please take a look at this when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv commented on PR #19446: URL: https://github.com/apache/kafka/pull/19446#issuecomment-2801849349 @FrankYang0529 Thanks for the review. I have addressed all your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv commented on PR #19446: URL: https://github.com/apache/kafka/pull/19446#issuecomment-2796479700 @mjsax @cadonna Hello, please take a look at this when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] MINOR: Small cleanups in streams tests [kafka]

wernerdv opened a new pull request, #19446: URL: https://github.com/apache/kafka/pull/19446 - Fixed typos - Fixed IDEA code inspection warnings - Removed unused fields and methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to