Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-08 Thread via GitHub
dajac merged PR #19642: URL: https://github.com/apache/kafka/pull/19642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-07 Thread via GitHub
dajac commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2078267361 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -1609,15 +1608,19 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegr

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-07 Thread via GitHub
lianetm commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2078260553 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -1609,15 +1608,19 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerInte

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-07 Thread via GitHub
lianetm commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2078036167 ## clients/src/test/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandlerTest.java: ## @@ -233,117 +279,226 @@ public void testFailedHandleRespo

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-07 Thread via GitHub
Copilot commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2077902387 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1512,64 +1513,71 @@ private OffsetFetchResponseHandler() {

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-07 Thread via GitHub
dajac commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2077898809 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -1609,15 +1608,19 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegr

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-07 Thread via GitHub
dajac commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2077894203 ## clients/src/test/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandlerTest.java: ## @@ -233,117 +279,226 @@ public void testFailedHandleRespons

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-07 Thread via GitHub
dajac commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2077881699 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java: ## @@ -60,221 +55,126 @@ public class OffsetFetchResponse extends AbstractResponse {

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-06 Thread via GitHub
lianetm commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2076053266 ## clients/src/test/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandlerTest.java: ## @@ -233,117 +279,226 @@ public void testFailedHandleRespo

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-06 Thread via GitHub
dajac commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2075128654 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java: ## @@ -60,221 +55,126 @@ public class OffsetFetchResponse extends AbstractResponse {

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-05 Thread via GitHub
dajac commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2074839488 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java: ## @@ -60,221 +55,126 @@ public class OffsetFetchResponse extends AbstractResponse {

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-05 Thread via GitHub
lianetm commented on code in PR #19642: URL: https://github.com/apache/kafka/pull/19642#discussion_r2073862478 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java: ## @@ -139,40 +139,52 @@ public ApiResult> handleR ) {

[PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-05 Thread via GitHub
dajac opened a new pull request, #19642: URL: https://github.com/apache/kafka/pull/19642 WIP - Opened to run all the tests with the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th