clarkwtc commented on PR #19071:
URL: https://github.com/apache/kafka/pull/19071#issuecomment-2709276660
@chia7712
No problem.
I fixed that similar issue.
Update the information at the top of the conversation.
--
This is an automated message from the Apache Git Service.
To respon
clarkwtc commented on code in PR #19071:
URL: https://github.com/apache/kafka/pull/19071#discussion_r1986517982
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java:
##
@@ -391,24 +386,20 @@ public void testStateStore() {
public void
shou
clarkwtc commented on code in PR #19071:
URL: https://github.com/apache/kafka/pull/19071#discussion_r1986517609
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java:
##
@@ -587,19 +577,16 @@ public void
shouldThrowNullPointerOnTransformValuesW
clarkwtc commented on code in PR #19071:
URL: https://github.com/apache/kafka/pull/19071#discussion_r1986517381
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java:
##
@@ -587,19 +577,16 @@ public void
shouldThrowNullPointerOnTransformValuesW
chia7712 commented on PR #19071:
URL: https://github.com/apache/kafka/pull/19071#issuecomment-2708926789
@clarkwtc #17767 introduces another similar issue. could you please it in
this PR as well?
```
> Task :tools:compileTestJava
Note:
/home/chia7712/project/kafka/tools/src/test/ja
chia7712 commented on code in PR #19071:
URL: https://github.com/apache/kafka/pull/19071#discussion_r1986194037
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java:
##
@@ -391,24 +386,20 @@ public void testStateStore() {
public void
shou
clarkwtc commented on PR #19071:
URL: https://github.com/apache/kafka/pull/19071#issuecomment-2695069201
@frankvicky
Sure, using declaring `KTable` during the building works as
well, Previously, I wanted to resolve declaring `KTableImpl` causing the unchecked cast by declaring `var`.
frankvicky commented on PR #19071:
URL: https://github.com/apache/kafka/pull/19071#issuecomment-2692787948
@clarkwtc
I don't think it must use `var`.
For example:
```
@Test
public void testStateStore() {
final StreamsBuilder builder = new StreamsBuilder();
clarkwtc commented on PR #19071:
URL: https://github.com/apache/kafka/pull/19071#issuecomment-2692783247
> Why change the type to `var` keyword?
@frankvicky
https://github.com/user-attachments/assets/58a40c28-7580-4296-a596-9c63632fd63f";
/>
This change is meant to resolve
clarkwtc commented on code in PR #19071:
URL: https://github.com/apache/kafka/pull/19071#discussion_r1976594492
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java:
##
@@ -587,19 +587,16 @@ public void
shouldThrowNullPointerOnTransformValuesW
m1a2st commented on code in PR #19071:
URL: https://github.com/apache/kafka/pull/19071#discussion_r1976553529
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java:
##
@@ -587,19 +587,16 @@ public void
shouldThrowNullPointerOnTransformValuesWit
m1a2st commented on code in PR #19071:
URL: https://github.com/apache/kafka/pull/19071#discussion_r1976553529
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java:
##
@@ -587,19 +587,16 @@ public void
shouldThrowNullPointerOnTransformValuesWit
12 matches
Mail list logo