Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

philipnee commented on PR #14390: URL: https://github.com/apache/kafka/pull/14390#issuecomment-1758845137 Hello @dajac @lianetm @kirktrue - I think the scope of this PR extended a bit beyond "replacing GroupState" because we've realized the member may join/leave the group anytime during it

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

lianetm commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1355058608 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -178,31 +176,34 @@ public DefaultBackgroundThread(final Time ti

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

lianetm commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1355025353 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -209,15 +213,21 @@ public NetworkClientDelegate.UnsentRequest toU

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

philipnee commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1353232858 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -180,19 +180,19 @@ CompletableFuture sendAutoCommit(final Map o

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

dajac commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1353179173 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -180,19 +180,19 @@ CompletableFuture sendAutoCommit(final Map offse