Re: [PR] MINOR: Remove waitUntilTrue from TestUtils.scala. [kafka]

2024-12-10 Thread via GitHub
Wuzhengyu97 closed pull request #18118: MINOR: Remove waitUntilTrue from TestUtils.scala. URL: https://github.com/apache/kafka/pull/18118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Remove waitUntilTrue from TestUtils.scala. [kafka]

2024-12-10 Thread via GitHub
Wuzhengyu97 commented on PR #18118: URL: https://github.com/apache/kafka/pull/18118#issuecomment-2531601899 @dengziming Thanks for the heads up, I've fixed the problem you mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] MINOR: Remove waitUntilTrue from TestUtils.scala. [kafka]

2024-12-10 Thread via GitHub
dengziming commented on PR #18118: URL: https://github.com/apache/kafka/pull/18118#issuecomment-2531559120 LGTM, except some improvement suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: Remove waitUntilTrue from TestUtils.scala. [kafka]

2024-12-10 Thread via GitHub
dengziming commented on code in PR #18118: URL: https://github.com/apache/kafka/pull/18118#discussion_r1878032077 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -393,6 +397,16 @@ public static void waitForCondition(final TestCondition testCondition, final

[PR] MINOR: Remove waitUntilTrue from TestUtils.scala. [kafka]

2024-12-10 Thread via GitHub
Wuzhengyu97 opened a new pull request, #18118: URL: https://github.com/apache/kafka/pull/18118 Removed the waitUntilTrue function from TestUtils.scala and replaced it with waitForCondition. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementatio