Re: [PR] MINOR: Refactored default resource type based auth [kafka]

github-actions[bot] commented on PR #18130: URL: https://github.com/apache/kafka/pull/18130#issuecomment-2814462967 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

github-actions[bot] closed pull request #18130: MINOR: Refactored default resource type based auth URL: https://github.com/apache/kafka/pull/18130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

github-actions[bot] commented on PR #18130: URL: https://github.com/apache/kafka/pull/18130#issuecomment-2735241446 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

Serwios commented on PR #18130: URL: https://github.com/apache/kafka/pull/18130#issuecomment-2552211075 Update. I made it simpler: Everything is in interface, only one extracted method. Regarding benchmark, on my laptop ETA is 8 hours XD, let me know if it's necessary @mumrah !

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

github-actions[bot] commented on PR #18130: URL: https://github.com/apache/kafka/pull/18130#issuecomment-2550248664 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

Serwios commented on PR #18130: URL: https://github.com/apache/kafka/pull/18130#issuecomment-2545577459 Hi, request for revbiew @AndrewJSchofield -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

Serwios commented on code in PR #18130: URL: https://github.com/apache/kafka/pull/18130#discussion_r1878925772 ## clients/src/main/java/org/apache/kafka/server/authorizer/DefaultResourceTypeBasedAuthorization.java: ## @@ -0,0 +1,144 @@ +package org.apache.kafka.server.authorizer

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

Serwios commented on code in PR #18130: URL: https://github.com/apache/kafka/pull/18130#discussion_r1878924442 ## clients/src/main/java/org/apache/kafka/server/authorizer/DefaultResourceTypeBasedAuthorization.java: ## @@ -0,0 +1,144 @@ +package org.apache.kafka.server.authorizer

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

overpathz commented on PR #18130: URL: https://github.com/apache/kafka/pull/18130#issuecomment-2532939808 In general, LGTML. Very good for your first MINOR change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

overpathz commented on code in PR #18130: URL: https://github.com/apache/kafka/pull/18130#discussion_r1878885824 ## clients/src/main/java/org/apache/kafka/server/authorizer/DefaultResourceTypeBasedAuthorization.java: ## @@ -0,0 +1,144 @@ +package org.apache.kafka.server.authoriz

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

overpathz commented on code in PR #18130: URL: https://github.com/apache/kafka/pull/18130#discussion_r1878884623 ## clients/src/main/java/org/apache/kafka/server/authorizer/DefaultResourceTypeBasedAuthorization.java: ## @@ -0,0 +1,144 @@ +package org.apache.kafka.server.authoriz

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

overpathz commented on code in PR #18130: URL: https://github.com/apache/kafka/pull/18130#discussion_r1878884623 ## clients/src/main/java/org/apache/kafka/server/authorizer/DefaultResourceTypeBasedAuthorization.java: ## @@ -0,0 +1,144 @@ +package org.apache.kafka.server.authoriz

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

Serwios commented on code in PR #18130: URL: https://github.com/apache/kafka/pull/18130#discussion_r1878875515 ## clients/src/main/java/org/apache/kafka/server/authorizer/Authorizer.java: ## @@ -182,114 +171,6 @@ default int aclCount() { * given type.

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

Serwios commented on code in PR #18130: URL: https://github.com/apache/kafka/pull/18130#discussion_r1878875515 ## clients/src/main/java/org/apache/kafka/server/authorizer/Authorizer.java: ## @@ -182,114 +171,6 @@ default int aclCount() { * given type.

[PR] MINOR: Refactored default resource type based auth [kafka]

Serwios opened a new pull request, #18130: URL: https://github.com/apache/kafka/pull/18130 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing