Re: [PR] MINOR: New year code clean up - misc [kafka]

2025-01-04 Thread via GitHub
github-actions[bot] closed pull request #15071: MINOR: New year code clean up - misc URL: https://github.com/apache/kafka/pull/15071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] MINOR: New year code clean up - misc [kafka]

2025-01-04 Thread via GitHub
github-actions[bot] commented on PR #15071: URL: https://github.com/apache/kafka/pull/15071#issuecomment-2571488474 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: New year code clean up - misc [kafka]

2024-06-23 Thread via GitHub
github-actions[bot] commented on PR #15071: URL: https://github.com/apache/kafka/pull/15071#issuecomment-2185520326 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] MINOR: New year code clean up - misc [kafka]

2024-03-25 Thread via GitHub
chia7712 commented on PR #15071: URL: https://github.com/apache/kafka/pull/15071#issuecomment-2017572670 any update here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINOR: New year code clean up - misc [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #15071: URL: https://github.com/apache/kafka/pull/15071#issuecomment-1923992830 This needs another rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] MINOR: New year code clean up - misc [kafka]

2024-01-11 Thread via GitHub
divijvaidya commented on PR #15071: URL: https://github.com/apache/kafka/pull/15071#issuecomment-1887126184 (rebased from trunk to resolve conflict, will merge after CI is sane) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] MINOR: New year code clean up - misc [kafka]

2024-01-04 Thread via GitHub
divijvaidya commented on code in PR #15071: URL: https://github.com/apache/kafka/pull/15071#discussion_r1442225284 ## trogdor/src/main/java/org/apache/kafka/trogdor/workload/TopicsSpec.java: ## @@ -67,8 +67,7 @@ public void set(String name, PartitionsSpec value) { }

Re: [PR] MINOR: New year code clean up - misc [kafka]

2024-01-04 Thread via GitHub
divijvaidya commented on code in PR #15071: URL: https://github.com/apache/kafka/pull/15071#discussion_r1442224965 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -1079,8 +1077,7 @@ private void clearAll() { }

Re: [PR] MINOR: New year code clean up - misc [kafka]

2024-01-04 Thread via GitHub
mimaison commented on code in PR #15071: URL: https://github.com/apache/kafka/pull/15071#discussion_r1442027962 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -1079,8 +1077,7 @@ private void clearAll() { }

Re: [PR] MINOR: New year code clean up - misc [kafka]

2023-12-27 Thread via GitHub
divijvaidya commented on PR #15071: URL: https://github.com/apache/kafka/pull/15071#issuecomment-1870147486 @ijuma requesting your review on this cleanup as well please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use