Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
ijuma commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899911671 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on PR #18358: URL: https://github.com/apache/kafka/pull/18358#issuecomment-2566059958 @chia7712 @ijuma Could you take a look when you are available? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu opened a new pull request, #18358: URL: https://github.com/apache/kafka/pull/18358 see https://github.com/apache/kafka/pull/18308#discussion_r1899834438 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test covera