Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-29 Thread via GitHub
junrao merged PR #15889: URL: https://github.com/apache/kafka/pull/15889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-29 Thread via GitHub
emitskevich-blp commented on PR #15889: URL: https://github.com/apache/kafka/pull/15889#issuecomment-2138093800 > Are the failed tests related to this PR, especially the following one? Not related, they are all flaky tests -- This is an automated message from the Apache Git Service.

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-28 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1617784166 ## clients/src/test/java/org/apache/kafka/common/metrics/stats/FrequenciesTest.java: ## @@ -102,58 +110,69 @@ public void testBooleanFrequencies() { }

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-28 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1617783141 ## clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java: ## @@ -475,28 +464,13 @@ public void testPercentiles() { Metric p50 = this.m

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-28 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1617776104 ## clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java: ## @@ -475,28 +464,13 @@ public void testPercentiles() { Metric p50 = this.m

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-28 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1617770678 ## clients/src/test/java/org/apache/kafka/common/metrics/stats/FrequenciesTest.java: ## @@ -89,8 +88,17 @@ public void testBooleanFrequencies() { }

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-28 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1617767952 ## clients/src/test/java/org/apache/kafka/common/metrics/stats/FrequenciesTest.java: ## @@ -73,14 +72,14 @@ public void testMoreFrequencyParametersThanBuckets()

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-28 Thread via GitHub
junrao commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1617667802 ## clients/src/test/java/org/apache/kafka/common/metrics/stats/FrequenciesTest.java: ## @@ -102,58 +110,69 @@ public void testBooleanFrequencies() { } @Test

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-23 Thread via GitHub
chia7712 commented on PR #15889: URL: https://github.com/apache/kafka/pull/15889#issuecomment-2127744276 Most failed tests can be fixed by #16044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-23 Thread via GitHub
junrao commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1611984550 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -106,44 +109,51 @@ public String toString() { public abstract double combin

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-23 Thread via GitHub
chia7712 commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1611395173 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -50,10 +50,13 @@ public void record(MetricConfig config, double value, long tim

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-23 Thread via GitHub
chia7712 commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1611391288 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -106,44 +109,51 @@ public String toString() { public abstract double comb

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610656953 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -50,10 +50,13 @@ public void record(MetricConfig config, double value, lo

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610656953 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -50,10 +50,13 @@ public void record(MetricConfig config, double value, lo

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610653813 ## clients/src/test/java/org/apache/kafka/common/metrics/stats/SampledStatTest.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
junrao commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610602287 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -106,44 +109,51 @@ public String toString() { public abstract double combin

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
chia7712 commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610336329 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -40,7 +40,7 @@ public abstract class SampledStat implements MeasurableStat {

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610406308 ## clients/src/test/java/org/apache/kafka/common/metrics/stats/RateTest.java: ## @@ -64,4 +69,31 @@ public void testRateWithNoPriorAvailableSamples(int numSamp

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610394442 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -50,10 +50,11 @@ public void record(MetricConfig config, double value, lo

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610393654 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java: ## @@ -72,29 +67,12 @@ public long windowSize(MetricConfig config, long now) {

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
junrao commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1608743345 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -50,10 +50,11 @@ public void record(MetricConfig config, double value, long timeM

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610223223 ## clients/src/test/java/org/apache/kafka/common/metrics/stats/RateTest.java: ## @@ -64,4 +69,30 @@ public void testRateWithNoPriorAvailableSamples(int numSamp

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610221659 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -110,40 +111,43 @@ public String toString() { protected void purgeOb

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610220213 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -110,40 +111,43 @@ public String toString() { protected void purgeOb

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-22 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1610219832 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java: ## @@ -82,7 +82,7 @@ public long windowSize(MetricConfig config, long now) {

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-17 Thread via GitHub
junrao commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1605350575 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -110,40 +111,43 @@ public String toString() { protected void purgeObsoleteSam

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-15 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1602477638 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java: ## @@ -63,33 +63,38 @@ public void record(MetricConfig config, double value, long tim

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-15 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1602153395 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java: ## @@ -63,33 +63,38 @@ public void record(MetricConfig config, double value, long tim

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-15 Thread via GitHub
junrao commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1602125187 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java: ## @@ -63,33 +63,38 @@ public void record(MetricConfig config, double value, long timeMs) {

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-12 Thread via GitHub
emitskevich-blp commented on PR #15889: URL: https://github.com/apache/kafka/pull/15889#issuecomment-2106339696 @chia7712 @junrao maybe you can take a look here? Not invasive change, test failures are not related to PR changes -- This is an automated message from the Apache Git Service. T

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-08 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1593310007 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -106,44 +106,55 @@ public String toString() { public abstract doub

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-08 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1593310007 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -106,44 +106,55 @@ public String toString() { public abstract doub

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-07 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1593310007 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -106,44 +106,55 @@ public String toString() { public abstract doub

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-07 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1593308659 ## clients/src/test/java/org/apache/kafka/common/metrics/stats/RateTest.java: ## @@ -64,4 +67,31 @@ public void testRateWithNoPriorAvailableSamples(int numSamp