jeffkbkim commented on PR #17221:
URL: https://github.com/apache/kafka/pull/17221#issuecomment-2379459579
Forgot to add a +1 😅
LGTM. thanks dimitar!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jeffkbkim merged PR #17221:
URL: https://github.com/apache/kafka/pull/17221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
jeffkbkim commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1778745194
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +178,39 @@ public void testHistogramDataReset() {
dimitarndimitrov commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1778573710
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +178,39 @@ public void testHistogramDataRes
jeffkbkim commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1776938178
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +178,39 @@ public void testHistogramDataReset() {
dimitarndimitrov commented on PR #17221:
URL: https://github.com/apache/kafka/pull/17221#issuecomment-2371225981
> looks like the build is failing. could you take a look?
For sure!
It's pretty great that the CI also looks at Java 11, 17, and 21 builds - I
didn't know that AK can ev
dimitarndimitrov commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1773302091
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +177,39 @@ public void testHistogramDataRes
dimitarndimitrov commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1773293797
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +177,39 @@ public void testHistogramDataRes
jeffkbkim commented on PR #17221:
URL: https://github.com/apache/kafka/pull/17221#issuecomment-2370715034
looks like the build is failing. could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jeffkbkim commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1772963066
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +177,39 @@ public void testHistogramDataReset() {
jeffkbkim commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1772911560
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +177,39 @@ public void testHistogramDataReset() {
jeffkbkim commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1772911560
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +177,39 @@ public void testHistogramDataReset() {
jeffkbkim commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1772911560
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +177,39 @@ public void testHistogramDataReset() {
dimitarndimitrov commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1771776869
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +177,39 @@ public void testHistogramDataRes
jeffkbkim commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1769334386
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +177,39 @@ public void testHistogramDataReset() {
dimitarndimitrov opened a new pull request, #17221:
URL: https://github.com/apache/kafka/pull/17221
### About
An encore of #17184, this addresses the race described
https://github.com/apache/kafka/pull/16949#discussion_r1750273695 and adds a
JMH benchmark comparing `HdrHistogram` with Ya
chia7712 commented on PR #17184:
URL: https://github.com/apache/kafka/pull/17184#issuecomment-2356980818
I did not merge it ... this (GitHub) bug happened before but I do have no
idea why Github so hate me :cry:
I guess GitHub get confused by the force-push from the bot
"airlock-co
dimitarndimitrov commented on PR #17184:
URL: https://github.com/apache/kafka/pull/17184#issuecomment-2356973790
@chia7712 did you merge this intentionally? This was in the process of being
rebased in addition to having some of its comments addressed. I don't think
reopening is an option no
chia7712 merged PR #17184:
URL: https://github.com/apache/kafka/pull/17184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
dimitarndimitrov commented on code in PR #17184:
URL: https://github.com/apache/kafka/pull/17184#discussion_r1763405483
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/HdrHistogram.java:
##
@@ -70,19 +69,20 @@ public HdrHistogram(
) {
dimitarndimitrov commented on code in PR #17184:
URL: https://github.com/apache/kafka/pull/17184#discussion_r1763330333
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/metrics/HistogramBenchmark.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (
dimitarndimitrov commented on code in PR #17184:
URL: https://github.com/apache/kafka/pull/17184#discussion_r1763328347
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/metrics/HistogramBenchmark.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (
jeffkbkim commented on code in PR #17184:
URL: https://github.com/apache/kafka/pull/17184#discussion_r1760215084
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/metrics/HistogramBenchmark.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
dimitarndimitrov commented on code in PR #17184:
URL: https://github.com/apache/kafka/pull/17184#discussion_r1757632083
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/metrics/HistogramBenchmark.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (
dimitarndimitrov commented on PR #17184:
URL: https://github.com/apache/kafka/pull/17184#issuecomment-2347304340
> because on my development machine I wasn't able to see consistent
reproducibility without more sophisticated testing tools like jcstress or
Byteman/BMUnit.
After a bunch
dimitarndimitrov opened a new pull request, #17184:
URL: https://github.com/apache/kafka/pull/17184
### About
Addresses the race described
[here](https://github.com/apache/kafka/pull/16949#discussion_r1750273695) and
adds a JMH benchmark comparing `HdrHistogram` with Yammer's histogram.
26 matches
Mail list logo
