Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-03-03 Thread via GitHub
cadonna merged PR #19043: URL: https://github.com/apache/kafka/pull/19043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-02-27 Thread via GitHub
cadonna commented on code in PR #19043: URL: https://github.com/apache/kafka/pull/19043#discussion_r1974015099 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestState.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-02-27 Thread via GitHub
kirktrue commented on code in PR #19043: URL: https://github.com/apache/kafka/pull/19043#discussion_r1973966726 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestState.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-02-27 Thread via GitHub
kirktrue commented on code in PR #19043: URL: https://github.com/apache/kafka/pull/19043#discussion_r1973966726 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestState.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-02-27 Thread via GitHub
cadonna commented on PR #19043: URL: https://github.com/apache/kafka/pull/19043#issuecomment-2687387498 Call for review: @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-02-26 Thread via GitHub
cadonna opened a new pull request, #19043: URL: https://github.com/apache/kafka/pull/19043 The AbstractHeartbeatRequestManager and the StreamsGroupHeartbeatRequestManager, both use the HeartbeatRequestState to track the state of the heartbeat requests. Both heartbeat request managers h