Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-06 Thread via GitHub
chia7712 commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1982864874 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; import jav

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-06 Thread via GitHub
smjn commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1982945047 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; import java.ut

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-06 Thread via GitHub
smjn commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1982945047 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; import java.ut

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-06 Thread via GitHub
smjn commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1982871587 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; import java.ut

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-05 Thread via GitHub
ijuma commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1982857330 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; import java.u

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-05 Thread via GitHub
smjn commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1981910462 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; import java.ut

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-05 Thread via GitHub
AndrewJSchofield commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1981904870 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; im

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-05 Thread via GitHub
junrao commented on code in PR #19057: URL: https://github.com/apache/kafka/pull/19057#discussion_r1981900730 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java: ## @@ -20,13 +20,33 @@ import org.apache.kafka.common.KafkaFuture; import java.

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-05 Thread via GitHub
AndrewJSchofield merged PR #19057: URL: https://github.com/apache/kafka/pull/19057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-04 Thread via GitHub
smjn commented on PR #19057: URL: https://github.com/apache/kafka/pull/19057#issuecomment-2698210918 @AndrewJSchofield @chia7712 Deleted common class. Duplicated methods of consumer within share. Please add CI tag. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] MINOR: Delete DeleteGroupsResult class. [kafka]

2025-03-04 Thread via GitHub
ijuma commented on PR #19057: URL: https://github.com/apache/kafka/pull/19057#issuecomment-2698208660 I agree that the logic we are trying to share is so simple that we don't need a public base class. If it's helpful, we could add internal utility methods that can be used by many of these r