Re: [PR] MINOR: Correcting Javadoc for ConnectAssertions [kafka]

2023-11-27 Thread via GitHub
yashmayya merged PR #14827: URL: https://github.com/apache/kafka/pull/14827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

Re: [PR] MINOR: Correcting Javadoc for ConnectAssertions [kafka]

2023-11-27 Thread via GitHub
vamossagar12 commented on code in PR #14827: URL: https://github.com/apache/kafka/pull/14827#discussion_r1405907500 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/ConnectAssertions.java: ## @@ -554,7 +554,7 @@ protected Optional checkConnectorState(

Re: [PR] MINOR: Correcting Javadoc for ConnectAssertions [kafka]

2023-11-27 Thread via GitHub
yashmayya commented on code in PR #14827: URL: https://github.com/apache/kafka/pull/14827#discussion_r1405891426 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/ConnectAssertions.java: ## @@ -554,7 +554,7 @@ protected Optional checkConnectorState( *

Re: [PR] MINOR: Correcting Javadoc for ConnectAssertions [kafka]

2023-11-26 Thread via GitHub
yashmayya commented on code in PR #14827: URL: https://github.com/apache/kafka/pull/14827#discussion_r1405642306 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/ConnectAssertions.java: ## @@ -524,7 +524,7 @@ public void assertConnectorIsStopped(String con

Re: [PR] MINOR: Correcting Javadoc for ConnectAssertions [kafka]

2023-11-23 Thread via GitHub
vamossagar12 commented on PR #14827: URL: https://github.com/apache/kafka/pull/14827#issuecomment-1824186109 hey @yashmayya , can you review this small PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] MINOR: Correcting Javadoc for ConnectAssertions [kafka]

2023-11-23 Thread via GitHub
vamossagar12 opened a new pull request, #14827: URL: https://github.com/apache/kafka/pull/14827 The 2 `checkConnectorState` method implementations have the following text in their return Javadocs: `* @return true if the connector and tasks are in RUNNING state; false otherwise`