wernerdv commented on PR #18937:
URL: https://github.com/apache/kafka/pull/18937#issuecomment-2718631246
@chia7712 Hello, could you please take a look when you have some free time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
wernerdv commented on PR #18937:
URL: https://github.com/apache/kafka/pull/18937#issuecomment-2703132016
@mumrah Could you please take a look when you have some free time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
wernerdv commented on code in PR #18937:
URL: https://github.com/apache/kafka/pull/18937#discussion_r1966554660
##
metadata/src/main/java/org/apache/kafka/metadata/VersionRange.java:
##
@@ -56,13 +56,6 @@ public boolean contains(short version) {
return version >= min &&
wernerdv commented on code in PR #18937:
URL: https://github.com/apache/kafka/pull/18937#discussion_r1966554660
##
metadata/src/main/java/org/apache/kafka/metadata/VersionRange.java:
##
@@ -56,13 +56,6 @@ public boolean contains(short version) {
return version >= min &&
wernerdv commented on code in PR #18937:
URL: https://github.com/apache/kafka/pull/18937#discussion_r1966554092
##
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##
@@ -466,11 +466,4 @@ public String toString() {
", partitionEpoch="
wernerdv commented on code in PR #18937:
URL: https://github.com/apache/kafka/pull/18937#discussion_r1966553844
##
metadata/src/main/java/org/apache/kafka/metadata/LeaderAndIsr.java:
##
@@ -75,10 +72,6 @@ public LeaderAndIsr(
this.partitionEpoch = partitionEpoch;
}
wernerdv commented on code in PR #18937:
URL: https://github.com/apache/kafka/pull/18937#discussion_r1966553603
##
metadata/src/main/java/org/apache/kafka/image/ClusterImage.java:
##
@@ -66,10 +66,6 @@ public Map controllers() {
return controllers;
}
-public
wernerdv commented on code in PR #18937:
URL: https://github.com/apache/kafka/pull/18937#discussion_r1966552907
##
metadata/src/main/java/org/apache/kafka/metadata/LeaderAndIsr.java:
##
@@ -133,20 +126,6 @@ public List isr() {
.collect(Collectors.toList());
wernerdv commented on code in PR #18937:
URL: https://github.com/apache/kafka/pull/18937#discussion_r1966550827
##
metadata/src/main/java/org/apache/kafka/controller/errors/ControllerExceptions.java:
##
@@ -40,21 +40,6 @@ public static boolean isTimeoutException(Throwable
excep
wernerdv commented on code in PR #18937:
URL: https://github.com/apache/kafka/pull/18937#discussion_r1966548309
##
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##
@@ -129,20 +129,6 @@ public TopicImage apply() {
return new TopicImage(image.name(), imag
wernerdv commented on code in PR #18937:
URL: https://github.com/apache/kafka/pull/18937#discussion_r1966548309
##
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##
@@ -129,20 +129,6 @@ public TopicImage apply() {
return new TopicImage(image.name(), imag
mumrah commented on PR #18937:
URL: https://github.com/apache/kafka/pull/18937#issuecomment-2672446385
Oh, also please refrain from force pushing now that the review has started
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
wernerdv commented on PR #18937:
URL: https://github.com/apache/kafka/pull/18937#issuecomment-2664058848
@cmccabe @mumrah Hello, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
wernerdv opened a new pull request, #18937:
URL: https://github.com/apache/kafka/pull/18937
Removed unused code and fixed IDEA warnings.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
14 matches
Mail list logo
