chia7712 merged PR #19852:
URL: https://github.com/apache/kafka/pull/19852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
sjhajharia commented on PR #19852:
URL: https://github.com/apache/kafka/pull/19852#issuecomment-2993683654
Thanks @chia7712
I just fixed the conficts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on PR #19852:
URL: https://github.com/apache/kafka/pull/19852#issuecomment-2993654666
@sjhajharia please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
sjhajharia commented on PR #19852:
URL: https://github.com/apache/kafka/pull/19852#issuecomment-2961206453
Gentle reminder
@frankvicky @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sjhajharia commented on PR #19852:
URL: https://github.com/apache/kafka/pull/19852#issuecomment-2934067128
Hey @frankvicky / @chia7712 ,
Inviting you for reviews too.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
sjhajharia commented on PR #19852:
URL: https://github.com/apache/kafka/pull/19852#issuecomment-2921204548
Thanks @m1a2st
I have addressed the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
m1a2st commented on code in PR #19852:
URL: https://github.com/apache/kafka/pull/19852#discussion_r2115018521
##
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##
@@ -116,21 +114,25 @@ class ShareFetchAcknowledgeRequestTest(cluster:
ClusterInstanc
sjhajharia opened a new pull request, #19852:
URL: https://github.com/apache/kafka/pull/19852
Now that Kafka supports Java 17, this PR cleans up the
ShareFetchAcknowledgeRequestTest.
The changes mostly include:
- Collections.singletonList() is replaced with List.of()
- Get rid of a
