Re: [PR] MINOR: Cleanup Core Module [kafka]

2025-04-07 Thread via GitHub
AndrewJSchofield merged PR #19372: URL: https://github.com/apache/kafka/pull/19372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] [MINOR] Cleanup Core Module [kafka]

2025-04-06 Thread via GitHub
sjhajharia commented on code in PR #19372: URL: https://github.com/apache/kafka/pull/19372#discussion_r2030211767 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2284,22 +2273,15 @@ CompletableFuture writeShareGroupState(List stateBatc private KafkaE

Re: [PR] [MINOR] Cleanup Core Module [kafka]

2025-04-06 Thread via GitHub
AndrewJSchofield commented on code in PR #19372: URL: https://github.com/apache/kafka/pull/19372#discussion_r2030206882 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2284,22 +2273,15 @@ CompletableFuture writeShareGroupState(List stateBatc private

Re: [PR] [MINOR] Cleanup Core Module [kafka]

2025-04-04 Thread via GitHub
sjhajharia commented on PR #19372: URL: https://github.com/apache/kafka/pull/19372#issuecomment-2779234357 Thanks @m1a2st for the review. I have addressed the comments and pushed a fresh commit. Pls review when possible. -- This is an automated message from the Apache Git Service. To r

Re: [PR] [MINOR] Cleanup Core Module [kafka]

2025-04-04 Thread via GitHub
m1a2st commented on code in PR #19372: URL: https://github.com/apache/kafka/pull/19372#discussion_r2029065027 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -357,7 +356,7 @@ public CompletableFuture { return isrSize == 0 && elrSize ==

[PR] [MINOR] Cleanup Core Module [kafka]

2025-04-04 Thread via GitHub
sjhajharia opened a new pull request, #19372: URL: https://github.com/apache/kafka/pull/19372 Now that Kafka Brokers support Java 17, this PR makes some changes in core module. The changes in this PR are limited to only the Java files in the Core module. Scala related changes may follow nex